New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MLAA postrocessing shader missing in GT6 and TLoU #11290
Comments
Also here is the list of titles with fully working MLAA shader on RPCS3:
This proves that RPCS3 is really capable to reproduce image quality 1:1 like real PS3 renders in those titles. |
For TLOU, if I enable GPU light patch & MLAA patch and disable MLAA in GUI, the light reflection and shadows are broken. But if I enable MLAA again in GUI menu when I restart the game, the light reflection and shadows are back (you can disable MLAA in GUI again,the light is still there) |
All those disabling patches is just temporary hacky workaround. And they are breaking a lot of nice things. When all RSX, SPU and PPU functions will be implemented, RPCS3 will render PS3 image correctly without those patches. |
You need RCB+WCB to allow cell to read and write to your GPU. |
WCB on haven"t any effects (and is better to get it off coz, if on, I can't reproduce the L&S back) |
The Anti Aliasing setting in the GPU tab is for MSAA, MLAA is removed with patches |
It's Anti-Aliasing (I thought it was MLAA in GUI) but the result is same : so, it's MSAA conflict ? |
You also need "Read Color Buffers" from the advanced tab enabled. MLAA is done on the CPU on PS3. |
@kd-11 |
@Tarek2013 P.S. - Antialiasing option (Auto or Disabled) in GPU tab and MLAA is a completely different things ! First is a hardware MSAA and it works on RSX. All games have no issues with this on RPCS3. MLAA is a postprocessing shader and it works on SPU's. |
Hi KD-11 ! |
@Linear524 |
@Tarek2013 |
@Linear524 Patches applied : My RPCS3 config : Core: Now, I close emulator then open it again As you can see, the light & shadows are back just coz I changed the anti-aliasing option. Here's the following log : To finish : Some clears :
|
Like I said - your problem is not in RPCS3 or Antialiasing option. Your config is a complete mess. The Last of Us don't have shadowing issues in current master branch of RPCS3. (Latest revisions are stable enough) |
@Linear524
Whatever, I tested with your config (I just put SPU cache as MEGA coz I did first with Safe mode and it's exactly same) and...I got the same effect (no light & shadows) ! Second step (Anti-Aliasing OFF) : Light & shadows STILL OFF Third step (Anti-aliasing ON again) : light & shadows are back !!! I tried to understand what kind of emulator's instruction could produce this effect but it's over my competences... Anyway ,thank for your help and wish Happy New Year to you and all RPCS3 team and users ! |
MLAA postprocess antialiasing shader currently missing on some titles but works well on others.
This issue about its missing implementation in Gran Turismo 6 and Last of Us.
The importance of this function is not only for properly clean and antialiased geometry (which is always nice) but also for other effects which working together in conjunction with MLAA - color tone adjustment, blur effects, bloom effects, film grain effects, and other tricks. When these titles can not use MLAA shader - other combined effects are missing too... So it would be very good to see fixed proper MLAA implementation. Image accuracy is very important for overall PS3 emulation.
Here is some screenshots with current RPCS3 condition: (watch in fullscreen fullsize screenshots in order to see jagged edges)
And here is screenshots from PS3 console:
P.S. - a little example for TLoU = if we activate MLAA disabling patch - it will cut off MLAA function and will also disable Color tone, Bloom layer on explosion fire, Film Grain effect, GodRays effect from sun and some light sources, and will break nice sound listening blurred image mode...
The text was updated successfully, but these errors were encountered: