Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering problems with Project DIVA - Dreamy Theater 2nd / extend, Virtua Fighter 5 and maybe other Sega games. #2221

Closed
RaulDJ opened this issue Nov 1, 2016 · 29 comments

Comments

@RaulDJ
Copy link

RaulDJ commented Nov 1, 2016

So, these games can now render almost 100% correctly, but there're still some problems that seem to be related to lightning.

For comparison, here's the same scene on:

The PS3: http://i.imgur.com/qgBHwNG.png
and on the emulator: http://i.imgur.com/H7V8lrl.png

We also have some more strange looking problems like this one, with glowing yellow things on the character clothes: http://i.imgur.com/TV8r8Yg.jpg

This last one is explained here #2221 (comment) by @Waelwindows .

Recent Renderdoc: https://my.mixtape.moe/lmlcpk.7z

@RaulDJ
Copy link
Author

RaulDJ commented Nov 9, 2016

That I'm not sure. What we know is that all the games that run with the same Sega engine are affected.

By the way @kd-11, are you still alive...?

@RainKikyou
Copy link

Well, then I should open a new post

@Waelwindows
Copy link

Waelwindows commented Nov 10, 2016

The glowing glitch is just a problem with the shader not able to swizzle the alpha channel correctly
for example, here i have the skirt's glow texture:
https://puu.sh/sdjeC/ba64dc2f11.png
what the shader attempts to do is to get the alpha channel, but instead it gets 1 (fully opaque)
which makes the texture look like this (not entirely correct as i had to re-create it in photoshop)
https://puu.sh/sdjEi/447f195a76.png

@RaulDJ
Copy link
Author

RaulDJ commented Nov 10, 2016

@Waelwindows

So the yellow glowing things don't have anything in common with the general "lightning" problem?

@Waelwindows
Copy link

@RaulDJ in short yes

@RaulDJ
Copy link
Author

RaulDJ commented Nov 10, 2016

@Waelwindows Thank you, I will correct my post now.

@kd-11
Copy link
Contributor

kd-11 commented Nov 10, 2016

Given the example produced by @Waelwindows we have some image formats that have incorrect interpretation. I'll return to rpcs3 contributions as soon as work lightens up. By the way, can someone post a trace of that glow error? I've seen similar bugs on some other titles where post-process bloom is overbright.

@RaulDJ
Copy link
Author

RaulDJ commented Nov 10, 2016

Thank you very much, @kd-11

Here's a Renderdoc of that in case it helps: https://aww.moe/rryiac.7z

@RaulDJ
Copy link
Author

RaulDJ commented Jul 25, 2017

I would like to give this one some visibility again.

Recently, these games run at almost perfect 60 FPS with no sync issues anymore, so these graphical bugs are the last thing remaining.

@AniLeo
Copy link
Member

AniLeo commented Sep 21, 2017

Retest with master.
If it's still an issue, you need to update the issue with recent RenderDoc or log if there's useful information in it.

@RaulDJ
Copy link
Author

RaulDJ commented Oct 11, 2017

@AniLeo Yes, every single graphic-related problem with these two games is happening right now exactly as they happened more than a year ago , nothing changed whatsoever. Logs apparently are useless in this case.

Here's a recent Renderdoc: https://my.mixtape.moe/lmlcpk.7z

2D titles on the songs of 2nd are still as broken as they were, but it seems I cannot capture anything from that game with Renderdoc, it makes files that are less than a MB.

@tominfhl
Copy link

So new to this but how can I help provide info on this issue. If this is fixed would it fix the shading issues in Virtue Fighter 5 Final Showdown?

@RaulDJ
Copy link
Author

RaulDJ commented Oct 14, 2017

@tominfhl I think so, as they apparently use the same engine.

@tominfhl
Copy link

tominfhl commented Oct 15, 2017

@RaulDJ Man ... these games are so close to perfect ... just this one last thing.

@RaulDJ
Copy link
Author

RaulDJ commented Oct 15, 2017

@tominfhl Yeah, tell me about it. I've been waiting for more than a year for some fixes but all the developers did in that period fixed nothing in these games except performance.

@RaulDJ
Copy link
Author

RaulDJ commented Oct 19, 2017

@AniLeo could you please add the tags "Vulkan" and "OpenGL" as it happens on both renderers?
Here's a log on Vulkan that goes from game boot until a song finishes loading: RPCS3.zip

Finally, please tell me what else do I need to do in order to drop the "needinfo" tag, I'll give any information needed.

@tominfhl
Copy link

@kd-11, @AniLeo, @Waelwindows ...Very keen on this too ... let me know what I can do to help.

@RaulDJ
Copy link
Author

RaulDJ commented Oct 31, 2017

@kd-11 Here's a Renderdoc of 2nd on a stage where even the background has broken shit (some plants): https://my.mixtape.moe/rgzprq.7z

Aside from lighting, the character has some weird textures too, similar to what @Waelwindows commented last year.

@tominfhl
Copy link

tominfhl commented Dec 1, 2017

Congrats on the new rpcs3 announcements! You guys are doing a great job. Interesting that none of the recent enhancements touched these issue. Is it some obscure use of the RSX chip by Sega that is not general enough to be resolved with other improvements?

@RaulDJ
Copy link
Author

RaulDJ commented Dec 1, 2017

@tominfhl Well, not a single update in this past year changed anything related to these problems so I don't think that these latest improvements doing nothing about them is strange whatsoever, lol. Clearly is something particular to these games' engine that has to be specifically adressed, and that never happened, sadly.

@cal321
Copy link

cal321 commented Dec 4, 2017

I want to contribute by describing my experience with Virtua Fighter 5 Final Showdown.
The colors aren't displayed correctly. Running Vulkan, a lot of stuff that is supposed to be white is displayed as red:

https://imgur.com/a/Z3yOg

With OpenGL, the floor of the stage seems better, but the character's skin is still too orange.
Speed and FPS-wise Vulkan runs smoothly, OpenGL is slow motion mode.

Here is some red text that I ran into when I compiled the game and ran it in Vulkan afterwards:

https://imgur.com/a/4UviP

my PC: i5-6500, GTX 1050 Ti, Win 10, 12GB Ram

@tominfhl
Copy link

tominfhl commented Jan 29, 2018

Gents/ladies ... it looks like there has been some progress .... https://youtu.be/UKTiohYXgeA

Here is the link to the experimental verion https://ci.appveyor.com/api/buildjobs/e4qhhqcak5vtykug/artifacts/rpcs3-v0.0.4-2018-01-28-9b698e48_win64.zip

I tested it and seems to me the problem is fixed.

@RaulDJ
Copy link
Author

RaulDJ commented Jan 29, 2018

OH MY FUCKING GOD EVERYTHING IT'S FUCKING FINALLY FIXED AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAHHHHHHHHHHHHHHHHHHHHHHHHHHHH!!!!

@tominfhl
Copy link

tominfhl commented Jan 29, 2018

I know right! Finally some love. Playing it on a 4k set now. There is some slowdown here and there but it might just be my processor. Other than that, this is the best I have ever seen this game.

@RaulDJ
Copy link
Author

RaulDJ commented Jan 30, 2018

Yeeeeeah, here's my obligatory celebration video: https://www.youtube.com/watch?v=VTucXFDEnK0

@AniLeo
Copy link
Member

AniLeo commented Jan 30, 2018

Is it fixed on master? If yes, close issue

@RaulDJ
Copy link
Author

RaulDJ commented Jan 30, 2018

@AniLeo The glowing thing seems to be still an issue in that particular stage I mentioned in the OP:
imagen

Renderdoc capture here: https://my.mixtape.moe/qzmesy.7z

@kd-11
Copy link
Contributor

kd-11 commented Jan 30, 2018

I'm closing it since its very likely they are all fixed. At least vf5 and the miku games are, the rest should have their own ticket since the bug is likely not related.

@kd-11 kd-11 closed this as completed Jan 30, 2018
@RaulDJ
Copy link
Author

RaulDJ commented Jan 30, 2018

@kd-11 Do we have to open another one for that issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants