Regression: Significant performance drop on recent builds

[kd-11]

While investigating performance bottlenecks in RsxThread I noticed that recent builds are rather slow compared to older builds from last year. I haven't bisected to find the commit that introduces this yet.
This is very noticeable on the car selection screen in outrun: online arcade where previously we got about 45 fps (opengl) but now only can manage 15 fps (12 with vulkan). I also noticed this slowdown on some youtube videos of hitman 2. Can any testers confirm this isnt an issue with my build?

@SakataGintokiYT
@Zangetsu38

[aakh1361]

Hi
I don't use of old build and unknown speed is low
but it is my test game
I hope that will help you

cpu xeon e5450 quad
ram 16 gig
video 780 ti oc

http://www.emunewz.net/forum/showthread.php?tid=163866&pid=241520#pid241520

[SakataGintokiYT]

@kd-11
Performance drop after merge this commit : 1c14d87

[Nekotekina]

Try to replace shared_mutex with

#include <shared_mutex>
using std::shared_mutex;
using reader_lock = std::shared_lock<std::shared_mutex>;
using writer_lock = std::lock_guard<std::shared_mutex>;

Possibly, only in some places. I recommend the latest commit.
I don't have a good material to test.

[SakataGintokiYT]

@Nekotekina
Can you make test build ?

[raven02]

I tested the latest build and the car selection scene seems to be back to normal speed . I got 36-37 fps using Vulkan renderer .

Dragon Ball Z : Burst Limit also get much better speed when compared to the old build

[Zangetsu38]

@raven02 no change for me 19 22 fps , same before ^^

[kd-11]

I will retest with latest master later.

[raven02]

Here it is from the car selection scene

[kd-11]

@raven02 This isn't fixed. Its improved a bit, but not fixed. If you let the car sit on the selection screen for a few seconds, performance tanks significantly. When testing on my main PC, performance is now stable around 25-35 fps while before it was 50-60. Its getting there, but not quite yet.

[raven02]

how about the one with ppu fix in latest build now ? it seems to be better

[kd-11]

That's the one I'm saying is better. Tested with build from #2351

[raven02]

@kd-11 , does it work good from you side ?

[kd-11]

Performance looks to be better than before on games that I can test at the moment. Will re-open if any issues persist.