LLVM assertion failed when loading from LLVM cache

[valpackett]

RPCS3 v0.0.4-14-gc435b328, FreeBSD 12-CURRENT, LLVM 4.0.1 (OS packaged LLVM, which is built with assertions enabled).

When a game does not have previously cached PPU code (right after compilation), it launches successfully.

When a game does have cached code, RPCS3 crashes on game launch:

Assertion failed: (ObjectBufferMap.find(Key) == ObjectBufferMap.end() && "Second attempt to perform debug registration."), function NotifyObjectEmitted, file /wrkdirs/usr/ports/devel/llvm40/work/llvm-4.0.1.src/lib/ExecutionEngine/GDBRegistrationListener.cpp, line 167.

Other projects have hit this assertion: https://sft.its.cern.ch/jira/browse/ROOT-7741

GDBRegistrationListener is used by MCJIT by default, looks like there's no way to unregister it (created in the constructor without saving a reference anywhere, and the vector of listeners is private).

[Nekotekina]

Did you try to build LLVM from the submodule?

[valpackett]

Yeah, just tested, the failure does not happen with LLVM from the submodule. It's not built with assertions.

[jbeich]

Bundled LLVM (e.g., after #4504) doesn't help. On FreeBSD 12.0-CURRENT small (e.g., Scogger HD, Bomberman Ultra) and medium-sized (e.g., Aquapazza) games don't crash on first launch but big ones (e.g., Persona 5) still do frequently. On older FreeBSD releases any game always crashes when using LLVM cache.

$ pkg install rpcs3 mesa-dri xkeyboard-config
$ service dbus onestart
$ rpcs3
QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-foo'
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
Assertion failed: (ObjectBufferMap.find(Key) == ObjectBufferMap.end() && "Second attempt to perform debug registration."), function NotifyObjectEmitted, file /wrkdirs/usr/ports/emulators/rpcs3/work/rpcs3-0.0.5-259-g76a1d0d8f/llvm/lib/ExecutionEngine/GDBRegistrationListener.cpp, line 167.
Abort trap

[scribam]

With the master branch (737db90), LLVM is now built exclusively from submodule and doesn't use OS packaged LLVM anymore.
I think this issue can be closed, what do you think about it @myfreeweb?

[jbeich]

OS packaged LLVM, which is built with assertions enabled

devel/llvm* packages on FreeBSD are built without LLVM_ENABLE_ASSERTIONS but downstream overrides CMAKE_*_FLAGS_RELEASE, losing default -DNDEBUG.
https://github.com/freebsd/freebsd-ports/blob/68f424f62259/Mk/Uses/cmake.mk#L84
https://github.com/Kitware/CMake/blob/v3.11.1/Modules/Compiler/GNU.cmake#L43