Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPU improvements [test only ASMJIT] #4504

Merged
merged 21 commits into from May 9, 2018
Merged

Conversation

Nekotekina
Copy link
Member

No description provided.

@JohnHolmesII
Copy link
Contributor

Working as expected, then.

@YaPeL
Copy link

YaPeL commented Apr 30, 2018

got a 8-10% speed increase on unnamed5 on my crapwell processor [not using tsx] nice job catto

@Kravickas
Copy link
Contributor

Kravickas commented Apr 30, 2018

GOW 3
5820k AVX+ only
Only on SPU ASMJIT
new error, intro continue E {SPU[0x2000001] Thread (BigCellSpursKernel1) [0x041c8]} SPU: Unexpected fallthrough to 0x41d4
RPCS3.log.gz

@JusicP
Copy link

JusicP commented Apr 30, 2018

The Orange Box regressed with SPU ASMJIT.
Now shows white screen. When you trying run it again rpcs3 spams in log this:

{RawSPU[0x2] Thread () [0x03a00]} MEM: Access violation reading location 0xe0202c18

@Nekotekina Nekotekina force-pushed the master branch 4 times, most recently from 0b6d639 to b23b7ae Compare April 30, 2018 22:47
@Illynir
Copy link

Illynir commented May 1, 2018

Drakengard 3 crash on ASMJIT now for the ingame but boot is good, ni no kuni has huge problem on rendering also.

@@ -106,9 +106,6 @@
</item>
<item>
<widget class="QRadioButton" name="spu_llvm">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the checkbox needs an update for the tooltip in the json file

@Xcedf
Copy link

Xcedf commented May 1, 2018

Great stuff, but nothing works for now, and ASMJit crashes the emu for almost every game i have

@Nekotekina Nekotekina changed the title SPU improvements SPU improvements [test only ASMJIT] May 1, 2018
@andredias000
Copy link

I also verify what @Xcedf said... For every game that I've tested the emu crashes and those who do not crash the emulator give a memory access reading violation

@resadent
Copy link

resadent commented May 1, 2018

Can also confirm +10-15% improvement in unnamed 5 with my crapwell processor. It's also good to be able to select spu llvm, even if it does nothing for now lol.

@Xcedf
Copy link

Xcedf commented May 1, 2018

Chose as test case Red Dead Redemption, cause it stucks or crashes faster than any on ASMJit
after 6f73654 game stucks on ASMJit, after 9dd11f5 it crashes the emu, works fine on all previous commits as on master

@AniLeo
Copy link
Member

AniLeo commented May 1, 2018

Get better test cases as a start, not RDR

@Xcedf
Copy link

Xcedf commented May 1, 2018

@AniLeo Doesn't matter, almost any game i have crashes or stucks sooner or later in a same way, with RDR it's sooner easier to test

Update: reverting SPUASMJitrecompiler.cpp and .h from 6f73654 fixes crashes for me, 9dd11f5 works just fine with this

@RPCS3 RPCS3 deleted a comment from NeoSlyde May 1, 2018
@RPCS3 RPCS3 deleted a comment May 1, 2018
@RPCS3 RPCS3 deleted a comment May 1, 2018
@RPCS3 RPCS3 deleted a comment May 1, 2018
@RPCS3 RPCS3 deleted a comment May 1, 2018
@AniLeo
Copy link
Member

AniLeo commented May 1, 2018

Exactly because it doesn't matter is why you should get better test scenarios, not some random difficult to debug game like RDR, otherwise devs will be wasting time by debugging it where they could be debugging something less complex.
It would only make sense if it was a RDR specific issue.


Removed spam from the PR, avoid off-topic and duplicate posts when the previous one can just be edited. This is going to be a PR with a lot of comments, so avoid useless posts.

@Nekotekina
Copy link
Member Author

I would like to see logs and exact description/screenshots of said ASMJIT crash.

@Xcedf
Copy link

Xcedf commented May 1, 2018

@AniLeo i don't think it's RDR specific
i also have this issue in:
Dante's Inferno crash during intro fmv
Persona 5 goes into menu and crahes a few moments later after starting a new game
GoW HD goes ingame but crshes after a few moments
GoW 3 crashes before intro fmv
all those issues are gone after i reverted the files i mentioned before
few other games i have crashes even sooner than RDR but they work too for me now
The only gmaes i have which work with this PR as it are Condemned 2, Infamous Demo, Journey
Didn't have time to test more since yesterday

@Nekotekina crashes look like this
5
and log for this if it helps
https://mega.nz/#!PBo3kbqA!5teuMc7GwuenIOe7OSSHfEdtnGzV1JSB0tqW5tmLeDw

@andredias000
Copy link

My Crash looks like this

desktop screenshot 2018 05 01 - 19 57 59 14

and the log file is here https://drive.google.com/open?id=1eZL39L9gpAnyImmwosWnXwDMOK1PtwN0
By the way the fatal error does not display anything because it crashes instantly before showing the window. The game that I am trying to boot here it Ratchet and Clank Trilogy.

When booting Heavy Rain, the emulator does not crash but gives the following error: F {PPU[0x1000000] Thread (main_thread) [0x0135e384]} MEM: Access violation reading location 0x0

@Nekotekina
Copy link
Member Author

Hopefully fixed

@Xcedf
Copy link

Xcedf commented May 1, 2018

Confirm, all my cases are fixed, and it seems some games became a little faster than before compare to master, thanks a lot

@MSuih
Copy link
Member

MSuih commented May 9, 2018

That was quick, the issue has been resolved and Uncharted works.

@Xcedf
Copy link

Xcedf commented May 9, 2018

Uncharted Trap fixed, Sonic Unleashed regression fixed

@Xcedf
Copy link

Xcedf commented May 9, 2018

Sorry for GoW Ascension false information game is nothing to do with Experimental commit, i just ran it on build full of hacks, to work on normal build it requires WCB+CpuBlit

@Nekotekina Nekotekina force-pushed the master branch 2 times, most recently from 2424a78 to 4176b5f Compare May 9, 2018 18:41
Remove SPU thread reference from spu_recompiler_base
Disable support for far jumps in pathpoints (they were rare and unsafe)
Don't fail if already exists
It was strangely removed...
@Xcedf
Copy link

Xcedf commented May 9, 2018

Killzone 3 Demo also ingame, but looks a way better
22

Shared between ASMJIT/LLVM recompilers, compiled at startup
Implemented utils::memory_release (not used)
Implemented utils::shm class (handler for shared memory)
Improved sys_mmapper syscalls
Rewritten ppu_patch function
Implemented vm::get_super_ptr (ignores memory protection)
Minimal allocation alignment increased to 0x10000
@Rpcs3tester
Copy link

@Nekotekina thanks this is noticeable speed

this fix Walking Dead: michonne sound stutting

also do good performance on a lot of games

@Shoegzer
Copy link

Borderlands now freezes at startup with this series of commits, throwing the following:

F {PPU[0x1000000] Thread (main_thread) [0x01001640]} St13runtime_error thrown: Memory mapping failed - blame Windows (addr=0x25f80000, size=0x20000, flags=0x23)

@MrJordanL
Copy link

This got killzone 2's skimirish mode to load in-game for the first time ever, but there's imcompatible formats that are causing it to have graphical bugs, i've put it in the issues.

Campaign mode still has same pink text error, and doesn't load in-game. but on the new SPU it has a different pink text error.

making the formats compatible could fix the graphical issues (possibly) and probably the same on killzone 1 and 3, who knows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet