Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop emulation button wrong behavior #6086

Closed
Realmantik opened this issue Jun 13, 2019 · 5 comments · Fixed by #7428
Closed

Stop emulation button wrong behavior #6086

Realmantik opened this issue Jun 13, 2019 · 5 comments · Fixed by #7428
Labels

Comments

@Realmantik
Copy link

After fatal memory errors (Access violation writing\reading location) pressing "stop emulation" causes closing of entire application. May be this happens after all fatal errors, I don't know.

@AniLeo
Copy link
Member

AniLeo commented Jun 13, 2019

That's very likely a crash, not the stop emulation functionality. Try the same thing with any of the other buttons.

@RainbowCookie32
Copy link
Contributor

Some games make the emulator crash after they froze/crash themselves. The Stop button should always close the game, not the emu. You can probably get the same behavior if you try to close the game's window

@Realmantik
Copy link
Author

Only "Stop emulation" closes the applicaion, But I have noticed another strange behavior, game window is not closed after fatal error happens, play button is activated, I can press it and emu runs some instructions of the game with the same result, memory access violation writing location (I tested only Mountain Crime: Requital game)

@Megamouse Megamouse added the GUI label Nov 16, 2019
@elad335
Copy link
Contributor

elad335 commented Feb 7, 2020

It's intentional with access violations, but I can improve it to not crash in specific situations for PPU threads, but not all of them.

@elad335
Copy link
Contributor

elad335 commented Feb 8, 2020

Play button is activated because Emu.Pause() is called immediatly afterwards. It also allows you to "replay" the violating memory access for debugging in case you suspect the memory was allocated afterwards.

@Megamouse Megamouse added Bug and removed GUI labels Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants