Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid closing the emulator after access violation #7428

Merged
merged 3 commits into from Feb 13, 2020
Merged

Avoid closing the emulator after access violation #7428

merged 3 commits into from Feb 13, 2020

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Feb 8, 2020 •
edited

  • Hack allocate memory at target address of access violation, then retry.
  • If the access violation was caused by writing to read-only memory, add a note about it in log and reprotect the memory with read-write protection, then retry.

This is done after emulation exit request has been issued, fixes #6086.

@elad335 elad335 requested review from AniLeo and Nekotekina and removed request for AniLeo February 8, 2020 01:10
@elad335 elad335 mentioned this pull request Feb 8, 2020
Merged
@Nekotekina Nekotekina merged commit 606693a into RPCS3:master Feb 13, 2020
@elad335 elad335 deleted the patch-4 branch February 13, 2020 12:38
@dyno0 dyno0 mentioned this pull request Feb 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nekotekina Nekotekina Awaiting requested review from Nekotekina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop emulation button wrong behavior
2 participants
@elad335 @Nekotekina