Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radv: Remove #7487 workaround #7897

Closed
AniLeo opened this issue Mar 29, 2020 · 5 comments · Fixed by #7909
Closed

radv: Remove #7487 workaround #7897

AniLeo opened this issue Mar 29, 2020 · 5 comments · Fixed by #7909
Assignees
Labels
Driver: RADV (Mesa) Open-source AMD Vulkan Mesa driver OS: Linux Render: Vulkan

Comments

@AniLeo
Copy link
Member

AniLeo commented Mar 29, 2020

Mesa fixed the issue that caused a performance regression, worked around in RPCS3 on #7487. The source of the issue was a lack of clarification on the Vulkan specification itself, which has also been added as of Vulkan 1.2.134 @ KhronosGroup/Vulkan-Docs@b275361#diff-267e1eca473d7e2ecbce0bc657a44d37R1465

The bug fix commit has been part of upstream mesa since 20.0.2:
https://gitlab.freedesktop.org/mesa/mesa/-/commit/aa3fe28d05316a83637d8ecca71ed75c6977767f

It has been decided to wait out a few weeks for distros to push the new mesa to their repositories (f. ex: arch's mesa is still on 19.3.4, with 20.0.2 still on Testing) and for users to be able to upgrade

@AniLeo AniLeo added Render: Vulkan OS: Linux Driver: AMD Vulkan Proprietary or amdvlk AMD Vulkan driver labels Mar 29, 2020
@AniLeo
Copy link
Member Author

AniLeo commented Mar 30, 2020

Ubuntu 20.04 Pre-Release was updated: https://launchpad.net/ubuntu/+source/mesa/20.0.2-1ubuntu1
Arch/Manjaro were updated: https://www.archlinux.org/packages/extra/x86_64/mesa/
openSUSE Tumbleweed was updated: https://software.opensuse.org/package/Mesa
Debian Unstable was updated: https://packages.debian.org/source/unstable/mesa

@kd-11 kd-11 self-assigned this Mar 31, 2020
@kd-11
Copy link
Contributor

kd-11 commented Mar 31, 2020

Noted. Will update.

@Leopard1907
Copy link

Fwiw , users with Ubuntu 18.04 based distros should be ok too if they use this PPA that Valve maintains. It is on 20.0.2 too.

https://launchpad.net/~kisak/+archive/ubuntu/kisak-mesa

@Cervoxx
Copy link

Cervoxx commented Mar 31, 2020

Fwiw , users with Ubuntu 18.04 based distros should be ok too if they use this PPA that Valve maintains. It is on 20.0.2 too.

https://launchpad.net/~kisak/+archive/ubuntu/kisak-mesa

If users will be required to update their mesa version, such as ubuntu 18.04 users, to use the application properly it would probably be wise to add a warning in the app to add this ppa and/or make a note about it in the quickstart guide.

It should be as simple as telling them to:

sudo add-apt-repository ppa:kisak/kisak-mesa
sudo apt upgrade
Then reboot.

The lutris wiki is a good source as well for getting updated video drivers on a linux distribution.

I wonder if we can bundle the updated mesa with the appimage, or if thats too far fetched.

@kd-11
Copy link
Contributor

kd-11 commented Mar 31, 2020

I have added the fix for this in with another workaround for Nvidia GPUs that I was told was fixed.

@AniLeo AniLeo added Driver: RADV (Mesa) Open-source AMD Vulkan Mesa driver and removed Driver: AMD Vulkan Proprietary or amdvlk AMD Vulkan driver labels Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Driver: RADV (Mesa) Open-source AMD Vulkan Mesa driver OS: Linux Render: Vulkan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants