[TESTERS NEEDED] vk: Explicitly declare null subpass dependencies #7487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately this doesn't fix the big performance loss on my RX580 since this commit in mesa https://gitlab.freedesktop.org/mesa/mesa/commit/e60de085473174e5a6b5a1e33e39006e62f5c786 |
kd-11
changed the title
|
Which is the first version of mesa affected? Does 19.3.4 have this issue? |
- We do not want any actual dependencies, but it turns out removing them entirely makes the driver add even worse dependencies.
kd-11
changed the title
|
Ok, there was a copypasta issue there with the bottom_of_pipe stage flag, resolved now. I checked on my end and performance is back to normal, but there are many other driver vendors and thorough testing is encouraged. Check for any difference (vs master and/or older drivers) in terms of fps or RSX load percentage (can be seen by setting overlay detail to high). |
|
Performance back to normal for me on mesa. Thanks kd-11. |
|
That is good news. Thanks for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out to properly remove subpass dependencies you have to declare at least two.
Seeks to address https://gitlab.freedesktop.org/mesa/mesa/issues/2502