Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: YoRHa theme background does not display (#9728) #9732

Closed
AniLeo opened this issue Feb 6, 2021 · 5 comments · Fixed by #9735
Closed

Regression: YoRHa theme background does not display (#9728) #9732

AniLeo opened this issue Feb 6, 2021 · 5 comments · Fixed by #9735

Comments

@AniLeo
Copy link
Member

AniLeo commented Feb 6, 2021

#9728 broke the background for me on the YoRHa theme at least on AppImage (Manjaro Gnome 20.2.1)


Before

Screenshot from 2021-02-06 20-18-06

After

image

@Nekotekina
Copy link
Member

Need to replace url(GuiConfig/ with absolute path location of the theme before loading it. I haven't found better solution, and I doubt it exists.

@AniLeo
Copy link
Member Author

AniLeo commented Feb 6, 2021

Why not maintain the previous behavior? The theme is supposed to be read from within the AppImage filesystem, and it worked fine

I can't add full path on the theme itself as it varies per OS and user paths

@Nekotekina
Copy link
Member

Idk what was previous because I didn't even have any themes in my AppImages, neither in my builds.

You misunderstand. You load the file, you replace pathes with absolute ones in memory, you use the file.

@AniLeo
Copy link
Member Author

AniLeo commented Feb 6, 2021

Could work but seems a bit hacky. I don't even understand what is the change that broke this in the first place.

@Nekotekina
Copy link
Member

I'll try to fix. Wild guess you manually copied GuiConfig to .config/rpcs3/ but I think this is not the right solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants