Commit mini-db #9728
Commit mini-db #9728
Conversation
|
I used CLI to create initial commit db because anonymous limit is 60 per hour. But once it's written it will only need to be rarely appended. It's also seems convenient to update from CLI if put in some script I use. |
Located in bin/git/commits.lst; Created with GitHub API with --get-commit-db key. Can be lazily appended with the same key.
|
I think that code can be moved out of main.cpp when it's properly (re)factored for actual use. The problem is, the information is spread, git frontend isn't installed, etc etc. Accessing old PR data is non-trivial, it's also hard to gather all information. |
Reduce quality of kot-bg.jpg.
|
RPCS3.log |
|
Agreed - i now get instacrash upon opening RPCS3 after updating - error shown is: |
|
Oh sorry, I think I'll fix it right now. |
| @@ -209,6 +209,12 @@ bool update_manager::handle_json(bool automatic, bool check_only, const QByteArr | |||
| m_expected_hash = latest[os]["checksum"].toString().toStdString(); | |||
| m_expected_size = latest[os]["size"].toInt(); | |||
|
|
|||
| if (!m_request_url.starts_with("https://github.com/RPCS3/rpcs3")) | |||
There was a problem hiding this comment.
Dangerous change, will break the update on every old build if we're ever forced to do another build host migration such as the previous GitHub -> AppVeyor
I want the ability to see commits associated with releases in RPCS3 interface. Recent commits can be fetched via github API, but I believe it still needs a base to not fetch more than necessary. Base can be updated lazily (by appending new commits).
Why manipulating resources, added some additions for Linux builds (AppImage, custom out of source builds) so they seem to be able to find themes.