Performance overlay improvements #9875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Megamouse
commented
Mar 1, 2021
•
Megamouse
commented
- Fixed a bug where the framerate/frametime graphs weren't resized when the font size was changed.
- Fixed a bug in the graph visualization. We never visually drew the rightmost possible vertex.
- Added config settings for "Framerate datapoints" and "Frametime datapoints"
- Added a new detail level "None", with this you'll be able to only show the graphs if you want to.
elad335
reviewed
Mar 1, 2021
| @@ -459,10 +465,15 @@ namespace rsx | |||
| [[fallthrough]]; | |||
| } | |||
| case detail_level::minimal: | |||
| { | |||
| [[fallthrough]]; | |||
There was a problem hiding this comment.
No compiler will warn about empty code fallback, FYI.
There was a problem hiding this comment.
I thought it was just to emphasize it so that an overzealous dev doesn't add some break;
And fix potential division by 0
Doesn't render anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.