Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Compile shaders when CELL is not running #10003

Merged
merged 2 commits into from Mar 30, 2021
Merged

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Mar 21, 2021

Previously RSX waited until PPU called sys_rsx syscalls to compile shaders, then it let SPU and PPU run at fullspeed when doing so which can choke CPUs with not many threads.
This is also a bug which can cause timeout assertations from CELL side at startup due to RSX not responding for long period of time at startup when compiling shaders. (emulation must not observe the time in which RSX compiles shaders)
To solve it compile shaders before CELL is running, do not wait for PPU to execute some syscall. In fact now PPU will wait until RSX has been fully initialized to execute any stuff.

@Megamouse Megamouse added the RSX label Mar 21, 2021
@Nekotekina Nekotekina marked this pull request as draft March 22, 2021 11:57
@elad335 elad335 force-pushed the shaders branch 3 times, most recently from 6f8efd4 to e2ef4c0 Compare March 22, 2021 17:42
@elad335 elad335 requested a review from Nekotekina March 22, 2021 17:45
@elad335 elad335 marked this pull request as ready for review March 22, 2021 17:49
@elad335 elad335 force-pushed the shaders branch 2 times, most recently from 3652b6f to 9a07d3b Compare March 29, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants