Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: Scheduler tooltip fix #10020

Merged
merged 1 commit into from Mar 26, 2021
Merged

Qt: Scheduler tooltip fix #10020

merged 1 commit into from Mar 26, 2021

Conversation

xddxd
Copy link
Contributor

@xddxd xddxd commented Mar 26, 2021

The tooltip wasn't appearing on unsupported CPUs, tested on an i5 2500.

@Megamouse
Copy link
Contributor

Megamouse commented Mar 26, 2021

What's wrong with the current code?
I still a wanna see what this is

@xddxd
Copy link
Contributor Author

xddxd commented Mar 26, 2021

In the current code when the combobox is disabled the tooltip doesn’t get changed from the one when it’s enabled.

@Megamouse
Copy link
Contributor

It shouldn't. The tooltip in master is a popup.

@MSuih
Copy link
Member

MSuih commented Mar 26, 2021

If TSX is disabled then the tooltip is changed in this way. I think it would be more consistant if scheduler behaved the same way

@xddxd
Copy link
Contributor Author

xddxd commented Mar 26, 2021

image
This is what it looks like on master, when it should be like this:
image

@Megamouse
Copy link
Contributor

No. I wanna know what this feature is.
Also, You didn't show the super obvious popup that comes when you hover on the option

@xddxd
Copy link
Contributor Author

xddxd commented Mar 26, 2021

I wanted originally for it to change the description, not add a pop up. My mistake. facepalm. I’ll change the wording.

@elad335
Copy link
Contributor

elad335 commented Mar 26, 2021

Maybe append the tooltip on master at the end. I think the warning about it being disabled should come first.

@elad335
Copy link
Contributor

elad335 commented Mar 26, 2021

Ans if its not disabled show the text on master first instead but still show the warning at the end. So users won't be confused after changing CPU.

@xddxd xddxd force-pushed the tooltipgobrr branch 2 times, most recently from b3317bc to cbd2de1 Compare March 26, 2021 13:21
@Megamouse Megamouse merged commit b978aa6 into RPCS3:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants