New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of non-LLVM build configurations #10030
Conversation
It will probably meet some resistance from devs, although I don't have any objections. |
no objections either. who gives a f*** about non llvm builds these days. right @clienthax :) |
oops, forgot to push the azure file. |
Not like they have worked in ages lol |
461ad0f
to
a9b98c2
Compare
Release seems to build on VS. |
that's nice and all but the code also needs cleanup with assuming LLVM_AVAILABLE preprocessor is defined. |
Can't you build without llvm on Linux? |
Yes, but it should be removed too to match windows side. See the following: |
For some reason I can already see some linux guy making a pull request to add it back in |
Don't rush, there is also BSD build which doesn't have precompiled binaries and has to use that option. |
Get rid of Release - LLVM and Debug - LLVM configurations as per the roadmap on the website. Now Release and Debug act like the LLVM configs. Also, SPIRV and glslang were building in debug mode regardless of the set configuration because the build type was not set in the vcxproj, so fixed that too.