Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of non-LLVM build configurations #10030

Merged
merged 2 commits into from Mar 29, 2021
Merged

Conversation

xddxd
Copy link
Contributor

@xddxd xddxd commented Mar 28, 2021

Get rid of Release - LLVM and Debug - LLVM configurations as per the roadmap on the website. Now Release and Debug act like the LLVM configs. Also, SPIRV and glslang were building in debug mode regardless of the set configuration because the build type was not set in the vcxproj, so fixed that too.

@Nekotekina
Copy link
Member

It will probably meet some resistance from devs, although I don't have any objections.

@Megamouse
Copy link
Contributor

no objections either. who gives a f*** about non llvm builds these days. right @clienthax :)

@xddxd
Copy link
Contributor Author

xddxd commented Mar 28, 2021

oops, forgot to push the azure file.

@clienthax
Copy link
Contributor

Not like they have worked in ages lol

@xddxd xddxd changed the title Get rid of LLVM build configurations Get rid of non-LLVM build configurations Mar 28, 2021
BUILDING.md Outdated Show resolved Hide resolved
@xddxd xddxd force-pushed the reducedtoatoms branch 5 times, most recently from 461ad0f to a9b98c2 Compare March 28, 2021 23:24
@Megamouse
Copy link
Contributor

Release seems to build on VS.
lgtm. (didn't really look at the solution files though)

@Megamouse Megamouse added Build and CI Anything related to the build process and continuous integration OS: Windows labels Mar 28, 2021
BUILDING.md Outdated Show resolved Hide resolved
@elad335
Copy link
Contributor

elad335 commented Mar 29, 2021

that's nice and all but the code also needs cleanup with assuming LLVM_AVAILABLE preprocessor is defined.

@Megamouse
Copy link
Contributor

Can't you build without llvm on Linux?

@MSuih
Copy link
Member

MSuih commented Mar 29, 2021

Yes, but it should be removed too to match windows side.

See the following:
https://github.com/RPCS3/rpcs3/blob/master/CMakeLists.txt#L16
https://github.com/RPCS3/rpcs3/blob/master/3rdparty/llvm.cmake

@Megamouse
Copy link
Contributor

For some reason I can already see some linux guy making a pull request to add it back in

@Nekotekina
Copy link
Member

Don't rush, there is also BSD build which doesn't have precompiled binaries and has to use that option.

BUILDING.md Outdated Show resolved Hide resolved
@Nekotekina Nekotekina merged commit 7cbafd6 into RPCS3:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build and CI Anything related to the build process and continuous integration OS: Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants