Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: fix game window position on multi monitor setups #10036

Merged
merged 2 commits into from Mar 30, 2021

Conversation

Megamouse
Copy link
Contributor

@Megamouse Megamouse commented Mar 29, 2021

@Megamouse Megamouse added the GUI label Mar 29, 2021
@Megamouse Megamouse force-pushed the logggs branch 3 times, most recently from 6ef5fc4 to 5b815f3 Compare March 29, 2021 23:49
@Megamouse Megamouse changed the title Qt: minor changes Qt: fix game window position on multi monitor setups Mar 29, 2021
@dio-gh
Copy link
Contributor

dio-gh commented Mar 30, 2021

Fixes positioning and size shenanigans on and from the secondary screen, but on the primary screen with 1.25x scaling the game window is now scaled by 1.25x also. Is that expected behaviour? Thought the expected behaviour is to not scale unless you can scale by an integer.

@Megamouse
Copy link
Contributor Author

We don't scale anything.
If your screen is set to 125% then obviously all apps that support hidpi will be automatically scaled.
So it's expected.

@Megamouse
Copy link
Contributor Author

If you don't want that you need to disable it or change the rounding policy

@Megamouse Megamouse marked this pull request as ready for review March 30, 2021 16:39
@Megamouse Megamouse merged commit e557c96 into RPCS3:master Mar 30, 2021
@dio-gh
Copy link
Contributor

dio-gh commented Mar 30, 2021

After testing a previous build I can at least confirm it's not a new change, so the PR is mergeable. It's not that I don't want or want something, I just didn't expect that we allow Windows to do non-integer scaling on the graphics output.

@Boii1
Copy link

Boii1 commented Mar 31, 2021

I have tested this build in Little Big Planet and it tanks the performances from 30FPS to 20-25FPS. Can't hit 30 FPS anymore. The previous update works perfectly fine and hits 30FPS with zero drops.

Specs:
5950X
RTX 3080
2x16GB DDR4 16 18 18 38
ROG Crosshair VIII Dark Hero

@elad335
Copy link
Contributor

elad335 commented Mar 31, 2021

@Boii1 Closed pull request is a bad place to report problems, open an issue instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dual screen woes with DPI mismatch as seasoning
4 participants