Loader/cellGame: Do not crash on invalid PSF files #10041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
changed the title
elad335
force-pushed
the
psf
branch
4 times, most recently
from
83c7b7b
to
d8a84f4
Compare
Megamouse
reviewed
Mar 30, 2021
elad335
force-pushed
the
psf
branch
6 times, most recently
from
f181f5b
to
9878015
Compare
|
Looks like you could keep |
Nekotekina
reviewed
Apr 3, 2021
elad335
force-pushed
the
psf
branch
3 times, most recently
from
9f90355
to
4b47a84
Compare
|
I meant, you could leave psf::load_object to return only psf::registry unconditionally and crash inside if it's loaded with error, this way a bunch of changes in various files may become unnecessary. |
elad335
force-pushed
the
psf
branch
2 times, most recently
from
e7a4529
to
0f97fe6
Compare
Avoid redundant copies of std::string.
Nekotekina
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it crashed the whole emulator if you renamed any random file to PARAM.SFO and place it inside the game/ELF directory.
Now even with hex editor modifying any bit from a valid PARAM.SFO you won't succeed in crashing the emulator. Includes checks from #9998 as well.
Reminder that games technically have permission to (over)write PARAM.SFO files bitwise in /dev_hdd0 game data directories for example so this is a fix for emulation as well. I have used this "feature" in hw tests in the past. cellGame already supports the appropriate error codes for invalid PARAM.SFO.