cli: set user-id per command line #10053
Conversation
Megamouse
added
the
CLI
Megamouse
force-pushed
the
gamewindow
branch
2 times, most recently
from
c4226ea
to
c119c35
Compare
|
That sure came by surprise :) |
rpcs3/Emu/System.cpp
Outdated
|
|
||
| if (id == 0) | ||
| { | ||
| return false; | ||
| fmt::throw_exception("Failed to set user ID '%s'.\nIt must consist of 8 digits and cannot be 00000000.", user); |
There was a problem hiding this comment.
throw_exception in main thread crashes the whole emulator... just log an error and return false. As a general practice use assertations only if there's absolutely no logical way the thread could continue normally after the unexpected condition has been met, or if it's really an unreachable condition by your perspective.
There was a problem hiding this comment.
updated.
There shouldn't be a code path that isn't properly controlled now.
|
These exceptions can only happen if the user puts in garbage in the cli (which they want to know immediately), or if something went really wrong in the user manager. Currently the user manager handles the IDs on its own. So it would indicate a programming error. |
Megamouse
force-pushed
the
gamewindow
branch
4 times, most recently
from
26bfa19
to
93605f3
Compare
closes #10052