Replace simple_type with std::common_type #10121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nekotekina
requested changes
Apr 16, 2021
rpcs3/util/atomic.hpp
Outdated
| @@ -1710,6 +1705,9 @@ class atomic_t<bool, Align> : private atomic_t<uchar, Align> | |||
| } | |||
| }; | |||
|
|
|||
| template <typename T1, usz Align, typename T2, usz Align2> | |||
| struct std::common_type<atomic_t<T1, Align>, atomic_t<T2, Align2>> : std::common_type<T1, T2> {}; | |||
There was a problem hiding this comment.
Looks like it's missing asymmetric specializations, where only left or right part is atomic_t, for example.
Suggested change
| struct std::common_type<atomic_t<T1, Align>, atomic_t<T2, Align2>> : std::common_type<T1, T2> {}; | |
| struct std::common_type<atomic_t<T1, Align>, atomic_t<T2, Align2>> : std::common_type<T1, T2> {}; | |
| template <typename T1, usz Align, typename T2> | |
| struct std::common_type<atomic_t<T1, Align>, T2> : std::common_type<T1, std::common_type_t<T2>> {}; | |
| template <typename T1, typename T2, usz Align2> | |
| struct std::common_type<T1, atomic_t<T2, Align2>> : std::common_type<std::common_type_t<T1>, T2> {}; |
|
During some experiments I found out that |
Nekotekina
approved these changes
Apr 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.