gl: Intel GPU shader fix #10264
Merged
gl: Intel GPU shader fix #10264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
added
Render: OpenGL
Driver: Intel
|
This is fine, but is intel still non-glsl4 compliant these days? They have upcoming mainstream hardware, may be worth checking if vector indexing works for them now. A lot of the intel-only workarounds are largely unmaintained. |
|
Yes it's still non-glsl4 compliant, because the first thing I tried was to skip the specific code to have it run the normal path without custom code, and it would not work at all. Well yes maybe their new hardware will fix this and it will be worth checking. |
kd-11
approved these changes
May 12, 2021
|
In that case we can keep the change. Hopefully newer hw and drivers handle this better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, I couldn't run anything with OpenGL on my Surface Pro 7 (i7 version), now it works.