vm_native.cpp: change rpcs3_vm name/location priority (Win32) #10442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Nekotekina
commented
Jun 11, 2021
Nekotekina
commented
- Prefer temp dir over RPCS3 cache dir
- Rename to rpcs3_vm_sparse.tmp
Prefer temp directory, rename to rpcs3_vm_sparse.tmp Try to remove archive attribute (doesn't work well).
Megamouse
reviewed
Jun 11, 2021
| { | ||
| ensure(f.open(fs::get_temp_dir() + "rpcs3_vm", fs::read + fs::write + fs::create)); | ||
| goto check; | ||
| } |
There was a problem hiding this comment.
I don't like the go-to. Can't you just add a bool instead?
There was a problem hiding this comment.
I like neither, need to refactor this crap anyway to search for various locations where temp file could be placed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.