Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of sys_uart #10515

Merged
merged 1 commit into from Jul 19, 2021
Merged

Initial implementation of sys_uart #10515

merged 1 commit into from Jul 19, 2021

Conversation

Vestrel
Copy link
Contributor

@Vestrel Vestrel commented Jul 5, 2021 •
edited

Implementation of sys_uart_* calls used by VSH to configure audio/video backend. Prerequisite for rsxaudio.

Reopen of #10513

@Megamouse Megamouse requested a review from Nekotekina July 8, 2021 21:15
@Vestrel Vestrel force-pushed the vuart-m branch 2 times, most recently from 55ab982 to 32525f6 Compare July 12, 2021 12:06
@Vestrel
Copy link
Contributor Author

Vestrel commented Jul 12, 2021

Done

@Megamouse Megamouse added the VSH label Jul 17, 2021
@elad335
Copy link
Contributor

elad335 commented Jul 19, 2021

@Megamouse Noone reviewed it yet.

@Megamouse
Copy link
Contributor

Then what are you waiting for 🐕

@elad335
Copy link
Contributor

elad335 commented Jul 19, 2021

I'm afk for 2 weeks.

kd-11
kd-11 requested changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@kd-11 kd-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get the requested changes done first. Most of it is just code structuring, the logical bits seem to be good to go.

@Hasster1
Copy link

Wow, it actually compiled past 64th module with this pr...

kd-11
kd-11 approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@kd-11 kd-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes have been applied; I will approve.
Please fix the very minor whitespace errors I highlighted and we can merge.

@kd-11 kd-11 merged commit e51d16a into RPCS3:master Jul 19, 2021
@Vestrel Vestrel deleted the vuart-m branch July 20, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nekotekina Nekotekina Nekotekina left review comments

@elad335 elad335 elad335 left review comments

@kd-11 kd-11 kd-11 approved these changes

Assignees
No one assigned
Labels
Firmware: HLE VSH
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Vestrel @elad335 @Megamouse @Hasster1 @Nekotekina @kd-11