Fully implement sceNpDrmVerifyUpgradeLicense

[NicknineTheEagle]

This brings sceNpDrmVerifyUpgradeLicense closer to what I believe real PS3 does.
You'll likely get some complaints from people who did not unlock their C00 games properly after this is merged. The correct process is to install unlock PKG and RAP for it.

[NicknineTheEagle]

This appears to noticeably slow down game list refresh. Not sure how acceptable that would be for the devs. Could probably use some testing to evaluate the impact more.

[NicknineTheEagle]

This appears to noticeably slow down game list refresh. Not sure how acceptable that would be for the devs. Could probably use some testing to evaluate the impact more.

Can potentially use a simplified check in the game list if necessary.

[NicknineTheEagle]

@Nekotekina Could you take a look at this, please? This PR has been hanging in pending for a while now.

[Nekotekina]

Just a note, even though it doesn't particularly matter, std::string_view is better passed by value not reference.

[bundangdon]

"You'll likely get some complaints from people". Indeed, and on that note I'll be using an older build for a while. Confusingly bad move.

[JimScript]

If you put the edat file into a folder named with the product code of the game, it works again, but you also should have a valid rap file as usual. (i.e. exdata/NPUAxxxxx/xxx.edat)

Edit: Sorry I meant to say what AniLeo is saying, but I guess I didn't say enough of the file path, what they are saying is correct.

[AniLeo]

The PR is correct, .edat files should be on dev_hdd0/home/00000001/exdata/TITLE_ID as a real console, not on the root exdata folder

They're directly installed there once you install your Unlock PKG, or when you dump your already installed .edat files from a console

If you don't have them there, simply move them

[bundangdon]

Totally respect you guys and your work, but you just made it more complicated with this addition. This move wasn't really necessary, and I think you'll get more complaints than compliments as I'm sure most of RPCS3 users do not have a "valid rap" nor have the means to do so.

[AniLeo]

.edat files may require a .rap file in order to be decrypted, same as game data. They already did before, you can't magically decrypt an .edat file without the AES-256 key, which is the .rap file. There's no functional change here.

Not all .edat files are encrypted (i.e. need a .rap file). If they didn't before, they also don't need it now.

[AniLeo]

To clarify, which seems to be your confusion: .rap files aren't required for mere formality. They're decryption keys. Without a .rap file, you can't decrypt content that requires it. The only theoretical way you'd be able to decrypt something without the (AES-256) key would be to bruteforce it, and the complexity of that means you'd need approximately 100 to 200 times the current age of the universe worth of time to do it, assuming you own a quantum computer.

[NicknineTheEagle]

"You'll likely get some complaints from people". Indeed, and on that note I'll be using an older build for a while. Confusingly bad move.

This is literally how it works on the real PS3. You install EDAT file and a RAP/RIF to decrypt it, same as with other PSN content. There's nothing confusing about it.

I'm sure most of RPCS3 users do not have a "valid rap" nor have the means to do so.

Most RPCS3 users also pirate their games. Doesn't mean developers have to support that.

[AniLeo]

Most RPCS3 users also pirate their games. Doesn't mean developers have to support that.

As I said above, it's technically impossible to do so regardless. Either the content is encrypted, and you need a decryption key, or it's not encrypted, and you don't.

[bundangdon]

"You'll likely get some complaints from people". Indeed, and on that note I'll be using an older build for a while. Confusingly bad move.

This is literally how it works on the real PS3. You install EDAT file and a RAP/RIF to decrypt it, same as with other PSN content. There's nothing confusing about it.

I'm sure most of RPCS3 users do not have a "valid rap" nor have the means to do so.

Most RPCS3 users also pirate their games. Doesn't mean developers have to support that.

Be that as it may, this was a pretty disappointing update to RPCS3. That being said though, keep up the good work

[AniLeo]

Making the emulator more accurate is a disappointing update because you need to move previously incorrectly installed files to the correct directory?
I've explained in the most simple way, if you can't understand C to read the code yourself or basic cryptography then there's no arguing, it's a one-side discussion with someone who doesn't want to listen.