Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TESTERS NEEDED] RSX: fix 'Working buffer not big enough' in Menu of Space invaders [NPUB30305] #10617

Merged
merged 2 commits into from Jul 27, 2021
Merged

[TESTERS NEEDED] RSX: fix 'Working buffer not big enough' in Menu of Space invaders [NPUB30305] #10617

merged 2 commits into from Jul 27, 2021
+2 −2

Conversation

Megamouse
Copy link
Contributor

Apparently adding an offset to a delta when trying to grow the heap wasn't such a good idea.

@Megamouse Megamouse changed the title [TESTERS NEEDED] RSX: fix 'Working buffer not big enough' [TESTERS NEEDED] RSX: fix 'Working buffer not big enough' in Menu of Space invaders NPUB30305 Jul 27, 2021
@Megamouse Megamouse changed the title [TESTERS NEEDED] RSX: fix 'Working buffer not big enough' in Menu of Space invaders NPUB30305 [TESTERS NEEDED] RSX: fix 'Working buffer not big enough' in Menu of Space invaders [NPUB30305] Jul 27, 2021
kd-11
kd-11 approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@kd-11 kd-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed previously, this is the correct fix afaict. Seems to be a remnant of a purpose change on the grow method's argument (it now means grow by X not grow to X)

This was referenced Jul 27, 2021
Closed
Closed
Closed
Closed
@Megamouse Megamouse merged commit 0a7a12b into RPCS3:master Jul 27, 2021
@Megamouse Megamouse deleted the kill_the_troll branch July 28, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kd-11 kd-11 kd-11 approved these changes

Assignees
No one assigned
Labels
Bugfix RSX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Megamouse @kd-11