Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign pad profiles #10704

Merged
merged 2 commits into from Aug 15, 2021
Merged

Redesign pad profiles #10704

merged 2 commits into from Aug 15, 2021

Conversation

Megamouse
Copy link
Contributor

Current/Old behavior:

(I'll use the XInput handler as an example, but this applies to all handlers)

  • A pad profile is always tied to a handler.
    So there can be multiple "Default Profiles" that each are meant for XInput, DS3 ... and so on.
  • The original idea was that you could just make an Xinput profile for yourself and for example a different Xinput profile for each family member. Then everyone just had to select their profile in the correct player tab in the pad dialog and everyone would be happy...
  • Changing the second Xinput pad's button mapping will also change all others unless you select a different profile for each.
  • The resulting folder structure is a mess... There are a huge amount of files per handler in multiple directories (InputConfigs for example)

Since this turned out to be super unintuitive I changed it to a hopefully less confusing method.

New Behavior:

  • Each profile is now responsible for all 7 players. There are no more explicit "Xinput Profiles" etc.
    So you can now for example create 7 XInput pads with different button mappings in the same profile.
  • You can create new profiles as before.
  • The new files are always located in "/config/input_configs/global/" or "/config/input_configs/<TITLE_ID>/"
    Except for "active_configs.yml" which saves the currently chosen profiles
  • You can still create one custom pad config per game.
    For now there is no way to create multiple profiles for a game, but it should be relatively easy to add if necessary

fixes #10410

@Megamouse Megamouse merged commit cad96ce into RPCS3:master Aug 15, 2021
@leebenss
Copy link

this update wiped all my gamepad configs and none of the buttons register as orange button for guitar hero

@Bak1997
Copy link

Bak1997 commented Aug 15, 2021

I dont know if this was the Update. But since today after installing the update i can no longer use my xbox controller in my games even tho it recognises the controller in the gamepad settings.

@Bak1997
Copy link

Bak1997 commented Aug 15, 2021

Update: I put back the previous version and my controller works again. So its definitely this update that messes it up

@slyponto
Copy link

I just want to reiterate that this pr WIPED ALL MY INPUT PROFILES.

I'll stick with previous build until someone with a good heart helps us.

@AniLeo
Copy link
Member

AniLeo commented Aug 16, 2021

Don't double post

Profiles were remade, you need to create them again. If they work after creating them then there's no issue, the problem is when it doesn't work after creating clean profiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input: Discuss a new design for input profiles.
5 participants