System: skip unnecessary fxo initializations #10838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
added
Loader
Megamouse
force-pushed
the
more
branch
2 times, most recently
from
c11ce69
to
cb9b806
Compare
This comment has been minimized.
This comment has been minimized.
Megamouse
changed the title
This comment has been minimized.
This comment has been minimized.
|
removed the RSX part |
elad335
reviewed
Sep 17, 2021
|
|
||
| // Load patches from different locations | ||
| g_fxo->get<patch_engine>().append_global_patches(); | ||
| g_fxo->get<patch_engine>().append_title_patches(m_title_id); |
There was a problem hiding this comment.
I think these functions can be inserted inside the constructor.
There was a problem hiding this comment.
They can, but I think it's not worth the trouble in case someone accidentally uses it non-statically
The progress_dialog and patch system aren't needed unless a game is started. Before, they were both initialized everytime we added a single game to the game list or even when simply started RPCS3. This both means that a thread was needlessly idling all the time and even worse: The patch.yml was read countless times when we didn't need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The progress_dialog and patch system aren't needed unless a game is started.
Before, the progress_dialog was initialized everytime we added a single game to the game list or even when we simply started RPCS3. This means that a thread was needlessly idling all the time.
The patch.yml was also read every time when we didn't need it, e.g. when changing the user.