Qt: add changelog to updater #10844
Merged
Qt: add changelog to updater #10844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No hyperlinks? :( |
|
I don't like the idea of hyperlinks personally. Giving everyone links straight to github is sure to give users with no understanding of github a great way to spam PR comment sections with an issue they ran into even though it has nothing to do with the PR. |
Not if you link to the commit itself. Sure, you can technically also leave comments there, but it's not obvious. |
|
I don't think any developer wants a constant flood of random strangers commenting on their Pull Requests, just because there's a link in the changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the changelog to the update dialog (as simple as possible).
Thanks to @AniLeo for adjusting the API.