vm: Fix vm::unmap #10855
Merged
vm: Fix vm::unmap #10855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elad335
commented
Sep 11, 2021
•
elad335
commented
- Make vm::unmap atomic, squash the memory unmapping process inside this function while still using the same VM mutex ownership. (previously the unmapping process was executed in the block destructor after this function finishes, if the last shared_ptr went out of scope)
- Make vm::unmap not fail due to random vm::get calls, shared_ptr reference count is no longer a condition.
- Fix sys_mmapper_free_address spuriously failing with EBUSY due to random vm::get calls.
- Fix sys_vm_unmap race condition due to non-atomic vm::unmap.
- Add an optional verification block ptr arg to vm::unmap, used by patches.
elad335
force-pushed
the
vm-unmap
branch
3 times, most recently
from
4c1ec8a
to
d54045d
Compare
* Make vm::unmap atomic, squash the memory unmapping process inside this function while still using the same VM mutex ownership. * Make vm::unmap not fail due to random vm::get calls, shared_ptr reference count is no longer a condition. * Fix sys_mmapper_free_address spuriously failing with EBUSY due to random vm::get calls. * Fix sys_vm_unmap race condition due to non-atomic vm::unmap. * Add an optional verification block ptr arg to vm::unmap, used by patches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.