Implement fs::file::get_id() #10904
Merged
Implement fs::file::get_id() #10904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
force-pushed
the
file-id
branch
2 times, most recently
from
2270f55
to
8b19050
Compare
elad335
commented
Sep 21, 2021
|
|
||
| FILE_ID_INFO info; | ||
|
|
||
| if (!GetFileInformationByHandleEx(m_handle, FileIdInfo, &info, sizeof(info))) |
There was a problem hiding this comment.
Windows' implementation is copied from MSVC's STL https://github.com/microsoft/STL/blob/d6f9987d7ec694b8599fe21e87e3653c36566223/stl/src/filesystem.cpp#L419
|
Why encrypted file view doesn't compare equal to its underlying file in the first place? |
|
Added fs::file_id::can_a_write_of_another_file_affect_both_files() for clean use for savestates. |
elad335
force-pushed
the
file-id
branch
4 times, most recently
from
b3ae2c7
to
eb6d632
Compare
File descripor ID with 2 provided ways to compare between them: 1. is_mirror_of(): Test if identical: For example: when LHS writes one byte to a file at X offset, RHS file be able to read that exact byte at X offset) 2. is_coherent_with(): Test if both files point to the same file: For example: if a file descriptor pointing to the complete file exists and is being truncated to 0 bytes from non- -zero size state: this has to affect both RHS and LHS files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mimicking std::filesystem::equivalent() when comparing two file IDs, also adds readable information about the types of the overriding classes.
This feature is needed for savestates.