Suggest tweaking the setting "Stub PPU Traps" after PPU trap #10921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
reviewed
Sep 25, 2021
rpcs3/Emu/Cell/PPUThread.cpp
Outdated
| @@ -1493,7 +1493,7 @@ void ppu_trap(ppu_thread& ppu, u64 addr) | |||
| // If stubbing is enabled, check current instruction and the following | |||
| if (!add || !vm::check_addr(ppu.cia, vm::page_executable) || !vm::check_addr(ppu.cia + add, vm::page_executable)) | |||
| { | |||
| fmt::throw_exception("PPU Trap!"); | |||
| fmt::throw_exception("PPU Trap! Sometimes tweaking the setting \"Stub PPU Traps\" can workaround this crash.\nBest values depend on game code, if unsure try 1."); | |||
There was a problem hiding this comment.
Suggested change
| fmt::throw_exception("PPU Trap! Sometimes tweaking the setting \"Stub PPU Traps\" can workaround this crash.\nBest values depend on game code, if unsure try 1."); | |
| fmt::throw_exception("PPU Trap! Sometimes tweaking the setting \"Stub PPU Traps\" can prevent this crash.\nBest values depend on game code, if unsure try 1."); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description is in the code itself.