Vulkan: Make upscaler dynamic (FSR on/off) #11115
Conversation
Megamouse
commented
Nov 4, 2021
•
Megamouse
commented
- Resets upscaler on settings change. Although FSR is currently marked as a dynamic config option, it couldn't change during gameplay.
- Fixes a theoretical bug that led to an unwanted respective missing call to scale_output when you change the upscaler in the settings just at the right moment
- Improves the FSR sharpening strength tooltip area by introducing a parent widget as tooltip target
The config option was marked as dynamic, but was never actually changed ingame
|
FSR Works dynamically currently, but you have to resize the game window or go in and out of fullscreen. Nice to see thats no longer required though! |
| @@ -384,6 +384,7 @@ class VKGSRender : public GSRender, public ::rsx::reports::ZCULL_control | |||
|
|
|||
| std::unique_ptr<vk::text_writer> m_text_writer; | |||
| std::unique_ptr<vk::upscaler> m_upscaler; | |||
| bool m_use_fsr_upscaling{false}; | |||
There was a problem hiding this comment.
There is no need to permanently store this
There was a problem hiding this comment.
I guess we need this to see the change in settings.
Is it possible to have a callback system for config settings? It would make things much cleaner for dynamic RSX options.
Like, if a checkbox value is changed, call some function.
There was a problem hiding this comment.
There's a function that is called when we save the settings dialog.
Idk if it's better to add that in
There was a problem hiding this comment.
Leave it as-is for now, that needs to be handled as a bigger job involving handling renderer restart gracefully.
