macOS moltenVK support and SIGBUS handling #11252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
added
Build and CI
Megamouse
reviewed
Dec 10, 2021
Megamouse
approved these changes
Dec 10, 2021
Nekotekina
reviewed
Dec 11, 2021
| @@ -130,8 +130,9 @@ LOG_CHANNEL(q_debug, "QDEBUG"); | |||
| dlg.exec(); | |||
| }; | |||
|
|
|||
| #ifdef __APPLE__ | |||
| #if defined(__APPLE__) && defined(BLOCKS) // BLOCKS is required for dispatch_sync, but GCC-11 does not support it | |||
| // Cocoa access is not allowed outside of the main thread | |||
There was a problem hiding this comment.
Can you pass []{ show_report(text); } lambda instead?
There was a problem hiding this comment.
He can't compile it, that's why he added the ifdef for BLOCK.
Or can you confirm it compiles?
There was a problem hiding this comment.
I'm just wondering if lambdas can be used instead of alien ^{} syntax, I think I saw some examples in wild.
There was a problem hiding this comment.
We won't know in this PR, as the author uses gcc11
kd-11
approved these changes
Dec 12, 2021
kd-11
pushed a commit
to kd-11/rpcs3
that referenced
this pull request
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the bare minimum graphics workarounds (disabling logicOp, renaming select -> selection, disabling native triangle fan) and trivial fixes to the Cmake file, SIGBUS handling, and removes the thread check in main.cpp
Texture/surface format workarounds are not included.