rsx: Remove zclip hackery

[kd-11]

• Calculates precise Z value as requested by the game.
• Works properly if the underlying Z format matches the PS3 1:1 but may cause minor problems otherwise. This is a problem on AMD where integer formats are non-existent for depth wider than 16 bits.

Fixes #8950

AMD is still broken, but that is because of a hardware limitation. It was always broken, so no regression on that front.
Needs testing as it interacts with a lot of titles that have weird clip volumes.

[Linear524]

Interesting PR... , will test all my titles tonight :)

[DaishinSilviaGT]

It regressed on AMD, GT6 has broken skyboxes
GPU: RX 470 4 GB
No_Skybox.log.gz

[kd-11]

It regressed on AMD, GT6 has broken skyboxes GPU: RX 470 4 GB No_Skybox.log.gz

I feared as much. I'll restore the unprecision hack for GPUs without integer Z buffers. This feature is completely useless in modern titles but it really helps with emulation :(

[ribolovac510]

The flickering is gone in Deadly Premonition, shadows looks the same as in the build before the regression.

PR:

rpcs3-v0.0.19-add0cb3d_win64.mp4

Master:

rpcs3-v0.0.19-13106-18f59d3b_win64.mp4

Old build:

rpcs3-v0.0.12-10844-2e88924c_win64.mp4

[MarioSonic2987]

Fixes broken candles and overbloom in Saints Row: Gat out of Hell (only in OpenGL).

Before:

After:

With Vulkan, it looks like this. It's not caused by this PR.

[kd-11]

@DaishinSilviaGT Please try with the new build when you can.

[Linear524]

Tested GT6 on my GF1080 - skybox is broken and it is not AMD issue... Nvidia shows the same bug:

[Linear524]

Other testing results:

• GoW Ascension = no changes compared to master branch
• GoW 3 = no changes
• Gran Turismo 6 = broken skybox, screenshots above. (tried all combinations with or without WDB,RDB, WCB,RCB... And CPU Blit) ... Maybe this skybox has too big Z value ?
• Journey = no changes
• Killzone 2 = no changes
• Killzone 3 = no changes
• Persona 5 = no changes
• The Last of Us = no changes

[coolllman]

I had the same, broken skybox GT6 on GTX 1660

[kd-11]

GT6 should be ok now. Please check for other regressions.

[Linear524]

GT6 should be ok now. Please check for other regressions.

Will test GT6 and other titles tonight :)

( P.S. - GT6 have some serious issues with hardware blitting, and only CPU blit currently working without constant flashing and particle bugs and only without WCB/WDB/RCB/RDB usage... MLAA antialiasing is broken too as well as bloom postprocessing. )

[coolllman]

Gt6 fixed! In Uncharted 3 strange stutters, in master all ok

[kd-11]

Gt6 fixed! In Uncharted 3 strange stutters, in master all ok

It would be helpful to get a short video clip demonstrating the problem.

[Linear524]

Confirm - GT6 skybox is fixed. All other titles I have shows no regression (^_^)

[coolllman]

Gt6 fixed! In Uncharted 3 strange stutters, in master all ok

It would be helpful to get a short video clip demonstrating the problem.
Ok, i will try tonight

[coolllman]

base-profile-20211222-18315901-online-video-cuttercom-1_Uk8jol60.online-video-cutter.com.2.mp4

Gt6 stutters too

[coolllman]

In master all good, test exe in master folder rpcs3, settings same

[Darkhost1999]

I don't see anything different in that 8 second clip than just how the game has performed for me since I got it.
Essentially saying that looks exactly the same as how the game performs on master. Can you edit and provide a comparison?

[coolllman]

No, not the same, 3 stutters in video, in master all clean, video upload limit 10mb big problem

[kd-11]

Unrelated, this code change changes shader accuracy and has nothing to do with rendering pipeline or performance. I thought the report was a regression causing graphical glitches but if its just performance stutters I'm confident it is caused by something else.

[coolllman]

Unrelated, this code change changes shader accuracy and has nothing to do with rendering pipeline or performance. I thought the report was a regression causing graphical glitches but if its just performance stutters I'm confident it is caused by something else.

I don't know why, but test all settings and this pr and Thread Scheduler: RPCS3 Alternative Sheduler give stutters, in master all good

[coolllman]

I go to Operation System scheduler, test with Alternative please

[coolllman]

Cod World at War black skybox too

[kd-11]

The PR is already merged. Please open a regression ticket and provide RSX captures for analysis.