-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rsx: Minor surface cache improvements #11335
Conversation
Reworked things a bit. Now even with log spam and surface removal active the performance impact is very low from some quick testing. Got 35fps -> 60fps even with the removal spam active in prince of persia. I've also tweaked the thresholds again, needs a retest. I'll need to figure out which titles were affected by the removal and verify that they still work. I can only remember SSX. |
On one hand this is good, since we have almost double the fps even with aggressive cleanup. We just need to tune the algorithm so that the performance hit due to surface removal should never be greater than the performance hit of actually consuming all those sections. |
Added some new logic that tracks actual overdraw and is much easier to calibrate. Verify if everything is OK now. |
By the way, it seems AC spams zcull a lot, relaxed zcull should be optimal for such titles. Likely makes the performance difference more obvious. |
Actually I can also see zcull crap in prince of persia logs. Likely because the engine is related, same suggestion applies to that one. |
AC never spammed Zcull stuff for me, was using Relaxed all the way. |
- It is much slower to attempt surface removal than to render duplicates on the host GPU
c2819f5
to
97dd7f9
Compare
Fixes #11316