macOS: Fix arrow keys #11355
Merged
macOS: Fix arrow keys #11355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to clarify, was this tested on laptop keyboard only or also on usb keyboards (apple and/or generic)? |
|
I've only tested this on my MacBook. It doesn't matter whether USB keyboards also require this workaround, because it's not worth checking what kind of keyboard the user has anyway. |
|
I just mean in the sense that it shouldn't break arrow keys on usb keyboards. |
|
I've just tested this with a USB keyboard, it works fine. |
|
I think this is conceptually wrong. |
nastys
force-pushed
the
patch5
branch
2 times, most recently
from
85d6ab7
to
457cc54
Compare
Megamouse
reviewed
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrow keys are considered to be part of the keypad on macOS.
While the d-pad can be remapped to the "numpad" arrows by the user, it causes inputs to work incorrectly, so we need to intercept these inputs anyway.