Revert recent file system changes #11370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is just a suggestion from me, I'm fine if it is rejected. |
|
Well, at least don't revert unrelated commits. |
|
Should be resolved now |
Merged
This was referenced Jan 13, 2022
Megamouse
reviewed
Jan 13, 2022
| @@ -931,7 +931,7 @@ game_boot_result Emulator::Load(const std::string& title_id, bool add_only, bool | |||
| break; | |||
| } | |||
|
|
|||
| if (fs::file sfb_file{parent_dir + "/PS3_DISC.SFB"}; sfb_file && !sfb_file.stat().is_directory && sfb_file.size() >= 4 && sfb_file.read<u32>() == ".SFB"_u32) | |||
| if (fs::file sfb_file{parent_dir + "/PS3_DISC.SFB"}; sfb_file && sfb_file.size() >= 4 && sfb_file.read<u32>() == ".SFB"_u32) | |||
| { | |||
There was a problem hiding this comment.
What was wrong with this line?
There was a problem hiding this comment.
I wasn't sure if it was related to the other changes and I decided to rather revert too much than too little and then have to do another revert. We can introduce the changes back in future PRs, its not a problem.
|
The emulator has stopped compiling PPU modules at all, both with a clean installation and with an installation on top of the old version, and just freezes for no apparent reason. |
kd-11
pushed a commit
to kd-11/rpcs3
that referenced
this pull request
Feb 14, 2022
* Revert "FS: use std::filesystem::u8path" This reverts commit cd016be. * Revert "VFS: fix missing path deliminators" This reverts commit 84753db. * Revert "Bugfix of Emulator::Load disc path searching" This reverts commit b9179de. * Revert "fs: Reimplement path resolving using std::filesystem::weakly_canonical" This reverts commit 0c4b2ff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #11178 broke path handling for Windows users as seen in #11360. The fixes in #11365 did not fully fix every use case and there's still a lot of complaints about broken path handling causing various issues.
Pull request #11367 aims to fix the remaining bugs, but I think we should roll back the entire feature and take our time to implement it properly instead of rushing in with one quickly merged and poorly tested fix PR after another.