rsx: Surface format remapping enhancements #11381

kd-11 · 2022-01-15T13:19:44Z

TODO:

Confirm XBGR8 behaviour on realhw
NVIDIA blur issue
Fix float16 issues

N/B: Colormask for XBGR is not subject to swapping - verified with hw test.

Fixes #8902

MarioSonic2987 · 2022-01-15T16:17:19Z

Fixes broken lighting in Watch_Dogs. Excessive blur is still here.

Before:

After:

rpcs3/Emu/RSX/GL/GLDraw.cpp

rpcs3/Emu/RSX/VK/VKGSRender.cpp

kd-11 · 2022-01-15T19:58:35Z

Check if blurriness is fixed.

MarioSonic2987 · 2022-01-15T22:38:27Z

Blur is fixed.

Darkhost1999 · 2022-01-15T23:53:45Z

Was going to see if Blur was fixed in Uncharted 3 because in master it looks like this without Relaxed zcull. Relaxed zcull fixes this specific area of act 9.
Master

But what may interest you is:
PR

All of these Fatal errors
RPCS3.log
Without patches
RPCS3.log
Save Files
BCUS98233_NDI_UNCHARTED3_BT_1.zip

Xcedf · 2022-01-16T02:30:48Z

@Darkhost1999 the issue that you showed is nothing to do with this PR, Motion Blur in Uncharted 3/TLoU never worked properly on rpcs3, for some reason it interferes with depth buffer, as a result smth like this

and Relaxed ZCull also fixes nothing
Approx ZCull

Relaxed

Enable Motion Blur patch if you want to rid of that thing and don't use Precise ZCull it may actually make this thing worse.

Darkhost1999 · 2022-01-16T02:59:29Z

How are you not getting fatal errors when trying to boot the game on the PR though?

Xcedf · 2022-01-16T03:10:45Z

@Darkhost1999 I don't know, just not happening, try to remove your shader cache.

Darkhost1999 · 2022-01-16T03:36:25Z

After File - all titles - remove shader cache
Games that have regressed in this PR
Angry birds Star wars
RPCS3.log
Battlefield 3 (Not the same error Just a freeze no fatal error)
RPCS3.log
Call of Duty Ghosts
RPCS3.log
Dante's Inferno
RPCS3.log

I have more. But yes I'm aware the Blur issue in Uncharted 3 is not related to this PR.
Whereas the fatal error is definitely related to this PR

Disable native float16 works to bypass this fatal error.

coolllman · 2022-01-16T04:55:34Z

Call of duty not work with this pr, when start stage result black screen, on master 13185 all good

RainbowCookie32 · 2022-01-16T05:02:07Z

13185 is the latest build, so if it's working now then it isn't really an issue?

coolllman · 2022-01-16T05:12:16Z

In this pr issue, on master all work

RainbowCookie32 · 2022-01-16T05:15:54Z

In this pr issue, on master all work

Then providing some info would be nice, like a screenshot of the issue and a log

coolllman · 2022-01-16T05:24:54Z

Freeze on cache load
RPCS3.log
Delete all caches, boot, but freeze on start stage
RPCS3.log

coolllman · 2022-01-16T05:28:24Z

Battlefield Bad Company 2 the same freeze on start

coolllman · 2022-01-16T05:29:09Z

Battlefield Bad Company 2 log
RPCS3.log

coolllman · 2022-01-16T05:29:40Z

I think more games affected, tonight i will test more games

SlyCooperReloadCoded · 2022-01-16T05:52:19Z

I'm testing the PR now, Watch Dogs fails to boot with the same fatal errors as Darkhost1999 is getting. Seems it's not an isolated instance. This is with no caches, so clearning my caches wouldn't help.

SlyCooperReloadCoded · 2022-01-16T05:56:59Z

Oh, and here's a log for that:
RPCS3.log

coolllman · 2022-01-16T06:06:31Z

With disable native float16 all work

SlyCooperReloadCoded · 2022-01-16T06:08:32Z

Wow, Disable Native Float16 Support does indeed fix the fatal errors, however I have a feeling this wasn't intended.

- NV GPUs have a tendancy to be off by a very small margin, breaking rendering when greaterThan/lessThan checks are used. - NOTE: Currently this setting is using the sRGB flag which indicates 8-bit output. Only one game is currently known to care about this behaviour so this is good enough for now.

kd-11 · 2022-01-16T10:30:15Z

Please retest if float16 bug is fixed.

coolllman · 2022-01-16T11:14:48Z

Float16 bug fixed, but fps drop from 60 to 33 in cod world war and maybe in other games(((
I will test later.

kd-11 · 2022-01-16T11:20:50Z

I'm confident the fps drop is not caused by this PR. It is more likely something else was merged into master between when you last tested master and when you tested this out. Nothing much has been changed here other than some GPU instructions getting added. Unless you're at 99% GPU load (which is unlikely unless you're using intel integrated graphics) then nothing should be different with this PR.

coolllman · 2022-01-16T11:21:57Z

Infamous 2 15fps drop too, all games huge fps drop, preloading cache and compiling cache now very long

coolllman · 2022-01-16T11:22:40Z

No, nothing merge

coolllman · 2022-01-16T11:23:23Z

Latest merge 13 hours ago

coolllman · 2022-01-16T11:26:17Z

I test on latest master,your pr with float16 bug and your fixed pr, and only on last pr fps problem
Gtx 1660 driver 497.29

kd-11 · 2022-01-16T11:30:23Z

I'll need other people to corroborate this as I cannot see any difference on my system.

Xcedf · 2022-01-16T11:57:59Z

Well I have a small drop in Infamous 2, I bet it goes to those rounding routines, but definitely not a 15fps hit.
master

pr

Darkhost1999 · 2022-01-16T12:31:38Z

Don't got Infamous 2 but I got Infamous
Sorry my spawn area is right next to some vents and I'm using remote desktop. But the point is FPS. Not visual quality.
Master

PR

Aka within the margin of error no perceived difference.
Oh and float16 fatal errors are gone.

coolllman · 2022-01-16T12:45:20Z

Update driver to 5.11.23 reboot pc and fps back, but on the 3 boot fps drop again, run master fps good, reboot pc fps back, boot game 5 times - fps drop and only reboot fix it, on master all works flawestly

kd-11 · 2022-01-16T13:30:32Z

Update driver to 5.11.23 reboot pc and fps back, but on the 3 boot fps drop again, run master fps good, reboot pc fps back, boot game 5 times - fps drop and only reboot fix it, on master all works flawestly

This is a known windows bug. It can happen with any rpcs3 version. Nobody knows what causes it and it never seems to occur on any dev machines that I am aware of.

coolllman · 2022-01-16T13:35:36Z

Strange, this first time i see this bug and only on pr, i try 15 times boot on master and never see this bug, when fps drop i try boot again many times and on pr fps low, i run master and fps is back, run again pr fps low.
Try anyone multiple boots various games, is fps drop?

- NV hw does not like the raw use of round()

kd-11 · 2022-01-16T14:02:17Z

Strange, this first time i see this bug and only on pr, i try 15 times boot on master and never see this bug, when fps drop i try boot again many times and on pr fps low, i run master and fps is back, run again pr fps low. Try anyone multiple boots various games, is fps drop?

No, I mean, I haven't rebooted my machine despite starting rpcs3 dozens of times and performance is the same. This issue has been around for a while, we never figured out why some people have it and not others.

@Xcedf I have altered the rounding behaviour slightly, check if it restores the 1-2fps difference observed.
We also need retesting of the original watchdogs bug, just to make sure I didn't accidently undo the fix.

kd-11 · 2022-01-16T14:04:26Z

Actually @coolllman the huge perf drop is because windows flagged rpcs3 as an unstable application and enabled some flags. See https://docs.microsoft.com/en-us/windows/win32/win7appqual/fault-tolerant-heap#:~:text=To%20disable%20Fault%20Tolerant%20Heap,longer%20activate%20for%20new%20applications.
I'm not sure why, the flag is applied to the executable name, which just means whatever name you have set for the executable was noted as crashing a lot and windows decided to move it to a special heap.

Xcedf · 2022-01-16T14:25:17Z

@kd-11 yes, have my 2fps back

MarioSonic2987 · 2022-01-16T14:32:32Z

Watch_Dogs bug is still fixed.

coolllman · 2022-01-16T14:55:03Z

Thank you kd-11, i will read about unstable application, in new pr all good, i change name exe

SlyCooperReloadCoded · 2022-01-16T16:59:59Z

float16 support now works, however I'm now getting device lost fatal errors during gameplay. I notice that I usually get occasional fatal errors whenever this game's shader cache reaches over 12000 objects, so I'm not sure if the fatal error I got was related to this or that.

lextra2 · 2022-01-16T18:52:31Z

No, I mean, I haven't rebooted my machine despite starting rpcs3 dozens of times and performance is the same. This issue has been around for a while, we never figured out why some people have it and not others.

Probably how Windows assigns threads (and with modern cpu boosting being very sensitive to temperature, different cores can sustain different boosts), background processes on startup or mainboard memory training for timings.
It's what I figured out from hundreds of hours of benching (not rpcs3). Probably wouldn't happen on Linux.

Megamouse added the RSX label Jan 15, 2022

kd-11 force-pushed the watchdogs branch from 36b11e0 to d955530 Compare January 15, 2022 16:44

Megamouse reviewed Jan 15, 2022

View reviewed changes

rpcs3/Emu/RSX/GL/GLDraw.cpp Show resolved Hide resolved

Megamouse reviewed Jan 15, 2022

View reviewed changes

rpcs3/Emu/RSX/VK/VKGSRender.cpp Show resolved Hide resolved

kd-11 force-pushed the watchdogs branch from 69a8107 to e02f0ee Compare January 15, 2022 22:09

kd-11 marked this pull request as ready for review January 15, 2022 22:59

kd-11 added 2 commits January 16, 2022 13:29

rsx: Surface format remapping enhancements

3994907

kd-11 force-pushed the watchdogs branch from e02f0ee to 66502b5 Compare January 16, 2022 10:29

rsx: Optimize 8-bit rounding logic a bit

fcdc6ad

- NV hw does not like the raw use of round()

kd-11 merged commit 3e794e7 into RPCS3:master Jan 17, 2022

nitroos-ai mentioned this pull request Jan 21, 2022

Watch_Dogs (NPEB01433) Garbage data being fed to RSX #10978

Closed

kd-11 deleted the watchdogs branch January 22, 2022 11:10

rsx: Surface format remapping enhancements #11381

rsx: Surface format remapping enhancements #11381

Conversation

kd-11 commented Jan 15, 2022 • edited

MarioSonic2987 commented Jan 15, 2022

kd-11 commented Jan 15, 2022

MarioSonic2987 commented Jan 15, 2022 • edited

Darkhost1999 commented Jan 15, 2022 • edited

Xcedf commented Jan 16, 2022

Darkhost1999 commented Jan 16, 2022

Xcedf commented Jan 16, 2022

Darkhost1999 commented Jan 16, 2022 • edited

coolllman commented Jan 16, 2022

RainbowCookie32 commented Jan 16, 2022

coolllman commented Jan 16, 2022

RainbowCookie32 commented Jan 16, 2022

coolllman commented Jan 16, 2022

coolllman commented Jan 16, 2022

coolllman commented Jan 16, 2022 • edited

coolllman commented Jan 16, 2022 • edited

SlyCooperReloadCoded commented Jan 16, 2022 • edited

SlyCooperReloadCoded commented Jan 16, 2022

coolllman commented Jan 16, 2022

SlyCooperReloadCoded commented Jan 16, 2022

kd-11 commented Jan 16, 2022

coolllman commented Jan 16, 2022 • edited

kd-11 commented Jan 16, 2022

coolllman commented Jan 16, 2022

coolllman commented Jan 16, 2022

coolllman commented Jan 16, 2022

coolllman commented Jan 16, 2022 • edited

kd-11 commented Jan 16, 2022

Xcedf commented Jan 16, 2022

Darkhost1999 commented Jan 16, 2022

coolllman commented Jan 16, 2022

kd-11 commented Jan 16, 2022

coolllman commented Jan 16, 2022 • edited

kd-11 commented Jan 16, 2022

kd-11 commented Jan 16, 2022 • edited

Xcedf commented Jan 16, 2022

MarioSonic2987 commented Jan 16, 2022

coolllman commented Jan 16, 2022

SlyCooperReloadCoded commented Jan 16, 2022 • edited

lextra2 commented Jan 16, 2022 • edited

kd-11 commented Jan 15, 2022 •

edited

MarioSonic2987 commented Jan 15, 2022 •

edited

Darkhost1999 commented Jan 15, 2022 •

edited

Darkhost1999 commented Jan 16, 2022 •

edited

coolllman commented Jan 16, 2022 •

edited

coolllman commented Jan 16, 2022 •

edited

SlyCooperReloadCoded commented Jan 16, 2022 •

edited

coolllman commented Jan 16, 2022 •

edited

coolllman commented Jan 16, 2022 •

edited

coolllman commented Jan 16, 2022 •

edited

kd-11 commented Jan 16, 2022 •

edited

SlyCooperReloadCoded commented Jan 16, 2022 •

edited

lextra2 commented Jan 16, 2022 •

edited