-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Emulator::GracefulShutdown() #11399
Conversation
3c94f70
to
65c43eb
Compare
I think "graceful" is better word, very strange to use "merciful" in computing. |
I think simply something like RequestShutdown wouldn't be too weird either |
Lol. C'mon guys. There's plenty of memes in the code like the last of Arse and other Easter eggs. Let's be merciful when killing a process. |
"Request" implies the ability to refuse, I choose "graceful". |
This build seems to cause RPCS3 to crash. It also does not behave the same way as sending the exit CMD. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you basically have to exit gracefully whenever you first call Kill during some user interaction (after GetBootConfirmation)
We most likely need a flag that tells us if we're still compiling at the beginning, so that graceful shutdown can just kill right away. |
This is already done by checking the send call in GraceFulShutdown, so it's probably safe to simply call GraceFulShutdown instead of kill in the gui |
I suggest adding a blocking MainWindow wrapper that simply calls (GracefulExit + ProcessEvents loop) and using that instead of the Kill calls that I pointed out |
644a6ad
to
0f315a6
Compare
rpcs3/Emu/RSX/Overlays/Shaders/shader_loading_dialog_native.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please only do new commits until we merge.
I don't want to re-read all the code again ^^
I think the only part that's wrong now is the GetBootConfirmation I mentioned earlier. (If you decline then it will spawn a new one right away).
After that is sorted out, I'll actuallly test it ;)
K I'll test tomorrow |
lgtm I guess. The TODO seems curious, but I'll merge if that's not a blocker |
Addresses #11397