Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vk: Improve sanity checks around subresource gathers #11425

Merged
merged 3 commits into from Jan 22, 2022

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Jan 22, 2022

  • Do not write out of bounds when loading resources in system memory
  • Take subresource Z into account when calculating coverage. It is possible to have the first slice covered but have the rest missing, we can just reupload in such a case.

Fixes device lost crash in MLB series and maybe other titles.

@ToothyViking
Copy link

Skate 3 Crashes everytime from 5-20 minutes into the game, happens to my friend too I have an intel core i7 9700k and he has an intel core i5 9400F
RPCS3.log
.

@kd-11
Copy link
Contributor Author

kd-11 commented Jan 22, 2022

Please use the build from the PR to test. From the logs I can see clearly you're not using the build generated by this PR.

@kd-11 kd-11 merged commit 2f7d38b into RPCS3:master Jan 22, 2022
@kd-11
Copy link
Contributor Author

kd-11 commented Jan 22, 2022

We already have a tracker for skate 3, please keep the discussion in that thread, #11096

@kd-11 kd-11 linked an issue Jan 22, 2022 that may be closed by this pull request
@kd-11 kd-11 deleted the mlb-device-lost branch January 22, 2022 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Skate 3 crashes after some time ingame
3 participants