Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Fix duplicate data removal checks in surface cache #11497

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Feb 6, 2022

Fix out-of-bounds access when tagging memory for duplicate removal. The algorithm needs to be moved to the GPU down the line to make use of hardware occlusion queries, but for now, let's also add some overrun cookie to ensure we're not corrupting the heap.

Fixes #11495
Fixes #11435

@Megamouse Megamouse added the RSX label Feb 6, 2022
@Jonathan44062
Copy link

I completed the chapter in the PR Build (Resistance 1), without any issues, thank you!

@Darkhost1999
Copy link
Contributor

Fixes

  • RSX: [Performance warning] Texture gather routine encountered too many objects! in Red dead Redemption.

@MSuih
Copy link
Member

MSuih commented Feb 7, 2022

Fixes

* RSX: [Performance warning] Texture gather routine encountered too many objects! in Red dead Redemption.

This PR just moved those messages to warn level so that they are not shown by default. You'll still find that message in log file or by adjusting the log level in ui

@kd-11 kd-11 merged commit 2d9f21a into RPCS3:master Feb 7, 2022
@kd-11 kd-11 deleted the insomniac-crashes branch February 11, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants