macOS: Add MoltenVK Semaphore setting and fix performance regression #11550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastys
changed the title
nastys
force-pushed
the
mvkfences
branch
3 times, most recently
from
dac90e2
to
541f4fd
Compare
kd-11
reviewed
Feb 18, 2022
nastys
force-pushed
the
mvkfences
branch
4 times, most recently
from
069ee8a
to
3aecec6
Compare
kd-11
reviewed
Feb 18, 2022
Megamouse
reviewed
Feb 18, 2022
nastys
force-pushed
the
mvkfences
branch
2 times, most recently
from
1615648
to
ce9d0fc
Compare
kd-11
approved these changes
Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since MoltenVK 1.1.7, due to synchronization issues making API calls randomly inaccurate, software emulation is used to simulate vkSemaphore, rather than MTLFence, when running under Rosetta or on NVIDIA. Software emulation causes screen tearing and a huge performance loss compared to MTLFence, with no real benefits for RPCS3.
This PR changes the default behaviour to MTLEvent + MTLFence (the former takes priority when not running under Rosetta or on NVIDIA), and adds a new option in the Debug tab to let developers change it at runtime.
Note that when using the loader library (libvulkan.1.dylib) instead of directly loading MoltenVK (libMoltenVK.dylib), the configuration cannot be set at runtime and the
MVK_ALLOW_METAL_EVENTSand/orMVK_ALLOW_METAL_FENCESenvironment variables must be manually set instead.