Use simpler C00 unlock EDAT check in GUI #11606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what kind of slowdown are we talking about? |
Approximately 500 ms with three unlocked C00 games installed. It's quite noticeable when starting RPCS3.
Probably, I would imagine that the slowdown is largely caused by decryption. Although I'm not sure how long VerifyEDATHeaderWithKLicense takes. |
elad335
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so GUI elements like game list and main window title bar use a simpler check for C00 unlock EDATs where it simply checks if .edat file with the required name exists. In-game sceNpDrmVerifyUpgradeLicense call still uses the full check. This remedies the slowdown of game list refresh introduced in the initial implementation and also appears to match XMB behavior.