cellGameGetParamString: improve readability and add some logic changes

[Megamouse]

Makes the whole cellGameGetParamString code a bit more readable.
I found the old code unnecessarily confusing.

Also changes the logic a bit:

• Add TODO to cellGameGetParamString check since it should theoretically only exist in debug mode
• Adds some checks to make sure that the getter is called when an access preparation function was set
• Restrict access by default

[elad335]

https://github.com/RPCS3/rpcs3/pull/11689/files#diff-05b6f9ef20e5fa88fbac2cb32b74e703a95abab4a948d560919019d00f8e06dfL518
The game relies on this.

[Megamouse]

Any more information?
For example when did the game fail ? During boot? Or during some other specific event?

[elad335]

This is the original issue #7039.

[Megamouse]

The game relies on this.

You trolled me real hard right now on this one xD
That line was restricting the access for HDD game data. Meaning the getter returns an error for the unusual param IDs.
Since the access is now restricted by default, the game should have no issues.

[AphelionWasTaken]

The digital version of A4O seems to work fine with this PR.

[Megamouse]

Anyone review again?

[JimScript]

Both Littlebigplanet 1 and 2 can't boot after this PR, 1 doesn't ever stay frozen and kicks you back to the emulator. Log:
RPCS3.log