Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TESTERS NEEDED] LLE cellVdec (libvdec.sprx) #11891

Closed
wants to merge 2 commits into from

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Apr 28, 2022

Test for siginificant prefomance changes. Report games that aren't or nearly aren't affected by this change as well so we would have somewhat reliable statistics over this change. This change applies mainly to cutscenes which are not performance ravenous anyways. Report your specs as well. With this pr in order to HLE libvdec.sprx you have to select it in Advanced -> Firmware Libraries, old configs with manually set LLEd libvdec will not flip to HLE loader and you need to go through this process again. If you have had HLE libvdec before this pr, this pr will flip it to LLE automatically without modifying the config.
This is an important step in making savestates a reality.

@elad335
Copy link
Contributor Author

elad335 commented Apr 28, 2022

Upload logs when HLEd so we had know if cellVdec has been used at all.

@elad335 elad335 changed the title [TESTERS NEEDED] LLE cellVdec [TESTERS NEEDED] LLE cellVdec (libvdec.sprx) Apr 28, 2022
@Megamouse
Copy link
Contributor

Megamouse commented Apr 28, 2022

How am I suppose to fix these if you hack it away man

@elad335
Copy link
Contributor Author

elad335 commented Apr 28, 2022

Ok I won't close these issues, and you can still fix them, and it's not a hack!

@kd-11
Copy link
Contributor

kd-11 commented Apr 28, 2022

This will still be slow depending on host hardware I reckon. It is more important to get testing done on those first. There are those who use rpcs3 on gaming handhelds and laptops.
On another note, this is destined for a reversal in future. CPU video decoding is so much worse compared to dedicated hardware even on integrated gpus that it would be irresponsible to leave it like this.

@elad335 elad335 marked this pull request as draft April 28, 2022 07:08
@Satan86
Copy link

Satan86 commented Apr 28, 2022

Out of the many games I tested, Gran Turismo 5, 6 and Need For Speed Undercover were the only ones with issues running videos, GT had stuttering and bad audio while NFS only had stuttering. I also tested WWE 2K14 which is a game that runs movies while ingame and it worked fine as well
Logs from all games I tested: https://drive.google.com/file/d/1mqvZRrcKrEfMgn_DTe4SRgEKDJ9AEMVe/view?usp=sharing
Tested with the Ryzen 5 5600x

@lightfirst
Copy link

lightfirst commented May 18, 2022

Tested 魔装機神FCOFFIN OF THE END, using libvede.sprx HLE will frozen, can't play videos,
libvede.sprx LLE make videos playable but low speed
LLE Logs https://www.mediafire.com/file/halbrll2awx8zcn
HLE logs https://www.mediafire.com/file/i28rn9yxjn0wflx

@elad335 elad335 closed this Jun 14, 2022
@elad335 elad335 deleted the patch-57 branch June 14, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants