Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPU: optimize conflicting PUTLLUC (No-TSX) #11932

Merged
merged 1 commit into from May 5, 2022

Conversation

Nekotekina
Copy link
Member

@Nekotekina Nekotekina commented May 5, 2022

Enable previously TSX-only optimization.
PUTLLUC Perf completed in 18821 ms (PS3: 3853 ms)
Becomes:
PUTLLUC Perf completed in 4460 ms (PS3: 3853 ms)

Enable previously TSX-only optimization.
@Megamouse Megamouse added CPU Optimization Optimizes existing code labels May 5, 2022
@Megamouse
Copy link
Contributor

Megamouse commented May 5, 2022

Master:

PUTLLUC Perf completed in 9884 ms (PS3: 3853 ms)

PR:

PUTLLUC Perf completed in 2535 ms (PS3: 3853 ms)

Edit: removed rather uninteresting data

@solarmystic
Copy link

On my 12400F

Master:

PUTLLUC Perf completed in 9664 ms (PS3: 3853 ms)

PR:

PUTLLUC Perf completed in 3522 ms (PS3: 3853 ms)

Amazing optimization.

@Xcedf
Copy link

Xcedf commented May 5, 2022

Almost TSX! this is my 12900k
SPU Test v1.1.2 by GalCiv
SPU Task Avalanche completed in 2747 ms (PS3: 2740 ms)
PPU/SPU Ping-Pong completed in 1306 ms (PS3: 3045 ms)
SPU MFC 64 Bits War completed in 4473 ms (PS3: 3370 ms)
PPU/SPU MFC 64 Bits War completed in 7061 ms (PS3: 4443 ms)
SPU Integer Perf completed in 1223 ms (PS3: 8666 ms)
SPU Float Perf completed in 329 ms (PS3: 2379 ms)
SPU SpinLock completed in 3918 ms (PS3: 4409 ms)
PUTLLUC Perf completed in 2844 ms (PS3: 3853 ms)
PUTLLC Perf completed in 2283 ms (PS3: 3364 ms)
PUT Perf completed in 1531 ms (PS3: 3984 ms)
Large PUT Perf completed in 1235 ms (PS3: 4454 ms)
--Completed 11 tests in 28953 ms--

My old 9900k TSX
SPU Test v1.1.0 by GalCiv
SPU Task Avalanche completed in 1399 ms (PS3: 2740 ms)
PPU/SPU Ping-Pong completed in 1897 ms (PS3: 3045 ms)
SPU MFC 64 Bits War completed in 3971 ms (PS3: 3370 ms)
PPU/SPU MFC 64 Bits War completed in 4685 ms (PS3: 4443 ms)
SPU Integer Perf completed in 1897 ms (PS3: 8666 ms)
SPU Float Perf completed in 489 ms (PS3: 2379 ms)
SPU SpinLock completed in 2617 ms (PS3: 4409 ms)
PUTLLUC Perf completed in 2490 ms (PS3: 3853 ms)
PUTLLC Perf completed in 1661 ms (PS3: 3364 ms)
PUT Perf completed in 933 ms (PS3: 3984 ms)
Large Put Perf completed in 1274 ms (PS3: 0 ms)
--Completed 11 tests in 23326 ms--

@Darkhost1999
Copy link
Contributor

Ryzen 5 3600

  • Master
    SPU Test v1.1.2 by GalCiv
    SPU Task Avalanche completed in 6179 ms (PS3: 2740 ms)
    PPU/SPU Ping-Pong completed in 3566 ms (PS3: 3045 ms)
    SPU MFC 64 Bits War completed in 8818 ms (PS3: 3370 ms)
    PPU/SPU MFC 64 Bits War completed in 11331 ms (PS3: 4443 ms)
    SPU Integer Perf completed in 5321 ms (PS3: 8666 ms)
    SPU Float Perf completed in 872 ms (PS3: 2379 ms)
    SPU SpinLock completed in 8416 ms (PS3: 4409 ms)
    PUTLLUC Perf completed in 14345 ms (PS3: 3853 ms)
    PUTLLC Perf completed in 3921 ms (PS3: 3364 ms)
    PUT Perf completed in 2038 ms (PS3: 3984 ms)
    Large PUT Perf completed in 5803 ms (PS3: 4454 ms)
    --Completed 11 tests in 70616 ms--

  • PR
    SPU Test v1.1.2 by GalCiv
    SPU Task Avalanche completed in 6164 ms (PS3: 2740 ms)
    PPU/SPU Ping-Pong completed in 3087 ms (PS3: 3045 ms)
    SPU MFC 64 Bits War completed in 8691 ms (PS3: 3370 ms)
    PPU/SPU MFC 64 Bits War completed in 11661 ms (PS3: 4443 ms)
    SPU Integer Perf completed in 3764 ms (PS3: 8666 ms)
    SPU Float Perf completed in 845 ms (PS3: 2379 ms)
    SPU SpinLock completed in 10670 ms (PS3: 4409 ms)
    PUTLLUC Perf completed in 5281 ms (PS3: 3853 ms)
    PUTLLC Perf completed in 3655 ms (PS3: 3364 ms)
    PUT Perf completed in 2180 ms (PS3: 3984 ms)
    Large PUT Perf completed in 4891 ms (PS3: 4454 ms)
    --Completed 11 tests in 60893 ms--

@Nekotekina Nekotekina merged commit 10b33d0 into RPCS3:master May 5, 2022
@Asinin3
Copy link
Contributor

Asinin3 commented May 5, 2022

Same FPS for me in Sonic Unleashed and Skate 2.

R9 5950x:
Master: PUTLLUC Perf completed in 6980 ms (PS3: 3853 ms)
PR: PUTLLUC Perf completed in 2507 ms (PS3: 3853 ms)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CPU Optimization Optimizes existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants