Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit range of driver wake-up delay slider #12056

Merged
merged 1 commit into from May 22, 2022

Conversation

MSuih
Copy link
Member

@MSuih MSuih commented May 21, 2022

The current wake-up delay has some problems:

  • The default increments of 200 µs is way too much and most issues could be solved by much smaller values.
  • Increasing wakeup delay to values above ~500 µs or so will most likely not provide additional stability, thus just degrading performance for no benefit. There's really no need to have excessive values selectable.
  • Some users might think the middle of ranges gives a balance of stability and performance, and highest value givest the best stability possible. The current selectable range will make these users add way too much wakeup delay to their games.

This PR limits the range of wake-up delay slider to more sensible values and decreases the default increment steps as well. Hopefully this guides users to use smaller values. The changes only affect the UI slider, so larger values can be still used by editing the config file directly.

Also adjusts the tooltop in settings to give a better explanation on what the setting does. Critique about my spelling and wording is welcome.

@caio2050
Copy link

Hello, I recommend leaving the Wake-Up Delay driver bar as it was before this change, for multi-task use including use in more than 1 (one) monitor avoiding possible locking in some heavy game, leaving only the label text as this is currently for recommendation purposes.

@RainbowCookie32
Copy link
Contributor

Even if multitasking, the massive limit that wake-up delay had before this PR is pointless, same for the huge steps. I don't think you'd need to go over 800us for stability, even while doing something else.

@caio2050
Copy link

Well, with the use it had in heavy games with values above 800us it was possible to finish them, in order to understand and wear programming was ideal for the previous configuration, including for this vulkan Api, such recommendation is constructive for other comments that may arise for not too advanced processors.

@RainbowCookie32
Copy link
Contributor

You can still increase it to your heart's content, you'll just have to use the config file instead.

@MSuih MSuih deleted the wakeupAdjustments branch May 23, 2022 02:57
@MSuih
Copy link
Member Author

MSuih commented May 23, 2022

To keep this more productive: Which values were you previously using, and have you tried the new maximum? What CPU are you using and what game is requiring such high values?

The current maximum value of 800 µs is already 1/20th of a frame in 60 fps. It's a lot of time to spend doing nothing. On PS3 the equivalent value is around 2 µs or so. Going even higher suggests that you're using the slidere for something it was not intended for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants