cmake: unbreak USE_SYSTEM_FLATBUFFERS #12089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- Checking for module 'flatbuffers>=2.0.0' -- Found flatbuffers, version 2.0.6 CMake Error at 3rdparty/CMakeLists.txt:24 (message): Flatbuffers flatc execute failed with: ''
MSuih
added
the
Build and CI
RipleyTom
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressed by #12014. Tested downstream. execute_process() seems to take arguments as separate words: replacing
${STATUS}with${FBS_CMD_ERROR}led toNo such file or directory.RESULT_VARIABLEis populated with1if what fails is notexecute_processbutflatcwhileexecute_processalready shows stderror contents by default.