ogl bringup part 1

[kd-11]

A rather large set of OpenGL fixes. Initially I was investigating one bug, but this backend has suffered from a lot of rot and is missing a lot of features. Highlights:

• Do texture deswizzling on the GPU. Cuts texture upload times by 80% in some games that use this RSX feature.
• Avoid needless state changes by committing to the central state management structure (gl_state)
• Rewrite the whole buffer object API to be bindless (DSA). This helps avoid leaking buffer bindings and improves performance.
• Rewrite the whole fbo API to be fully DSA as well.
• Works around poor OpenGL performance on AMD proprietary drivers. Investigations show they do not properly support persistent mapped index buffers. If you do this, on every draw call the index data is manually copied over inline. Ouch.
• Optimize OGL compute dispatches.
• Optimize texture upload utils by using simple_array instead of vector. Turns out vector tries to zero-initialize the array which we do not want since this is just some scratch memory. Saves around 3ms in my test scenario (resogun)
• Implements buffer-to-d24x8 shader pipes to avoid CPU readback for typeless operations (mesa + AMD)

Fixes some issues too:
Fixes #12083
Fixes #12082

Also partially addresses #11197
And hopefully #11941

[kd-11]

This PR doesn't resolve all OpenGL issues, there is still a ton of work to be done there. But at least I now know what the main problems are and how to resolve them. Some redesign will have to be done for this backend in the coming days to at least make it usable as a fallback.

[Realmantik]

I tested Resident Evil Veronica. Texture upload time has imroved significantly and fps now ~30 in comparison with master build (~12). But PR introduces some artefacts. See screenshots:

master build

PR

[RainbowCookie32]

This PR fixes the menus on Uncharted 1 on OpenGL, but framerate got nuked out of orbit (from 60fps to 4).

Master:

PR:

Log if it's worth anything:
RPCS3.log.gz

Edit: Same deal with Split/Second:

Master:

PR:

RPCS3.log.gz

[kd-11]

Marked draft. I'll investigate all the regressions reported:

• RE veronica artifacts
• RDR artifacts
• UC1 broken ingame visuals
• UC1 performance
• Split/Second performance

Even if I cannot fix them right now if the scope is too large, I'll try and find out the root cause and open a tracker with pending work.

[Linear524]

@kd-11,
Thank you for reanimation of OpenGL and keeping this backend alive ! :)
OpenGl is a grandfather to all other latest API's, and it's the best gift from 3dfx Voodoo era. Even real PS3 graphics API is tweaked OpenGL...
Sometimes it is an important thing to compare RPCS3 rendering bugs between Vulkan and OpenGL in order to track down some issues.

[kd-11]

Time for a retest @RainbowCookie32 @Realmantik

[RainbowCookie32]

Performance is back on both games 👍🏼

[Darkhost1999]

Fixes #12082 and looks good doing it

[kd-11]

That's enough for this PR. The last main remaining issue is AMD performance doing untyped copy (for bitcasts). That will need custom compute or graphics pipelines to basically reimplement glGetTexSubImage/glTexSubImage in shaders.

[ghost]

Just a heads up @kd-11, I've seen multiple people on AMD GPUs with RPCS3 crashing with this error that's solved by reverting to 0.0.22-13670 (the build before this PR)

E RSX: ERROR: 0:44: 'f32_to_d24' : no matching overloaded function found 
ERROR: 0:44: 'assign' : cannot convert from ' const float' to ' temp highp uint'
ERROR: 0:44: '' : compilation terminated 
ERROR: 3 compilation errors. No code generated.


E RSX: 
F {RSX [0x0082920]} SIG: Thread terminated due to fatal error: Failed to compile compute shader```

[kd-11]

Just a heads up @kd-11, I've seen multiple people on AMD GPUs with RPCS3 crashing with this error that's solved by reverting to 0.0.22-13670 (the build before this PR)

E RSX: ERROR: 0:44: 'f32_to_d24' : no matching overloaded function found 
ERROR: 0:44: 'assign' : cannot convert from ' const float' to ' temp highp uint'
ERROR: 0:44: '' : compilation terminated 
ERROR: 3 compilation errors. No code generated.


E RSX: 
F {RSX [0x0082920]} SIG: Thread terminated due to fatal error: Failed to compile compute shader```

No new code was added doing a f32 conversion, which means it was always broken but another bug prevented the code from being run. Please open a ticket with steps on how to reproduce so I can investigate.

[Realmantik]

Resident Evil Code Veronica still has artifacts. Many tickets have already been opened about regression, so I will open a ticket if it will not be fixed in future patches.