HLE improvements #1216
Merged
HLE improvements #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also improved cellPadPeriphGetInfo
|
Maybe you will fix all the issues firstly. |
|
@Nekotekina Those issues being? |
|
I hoped you would remove that HLE license area option and remove the "sign in dialog" since it's useless and only looks confusing. Plus l10n changes are insane. I already said that converter format is just |
|
@Nekotekina Seems like I missed the s_round thingy for the License area. Thanks for pointing out, I have fixed it. I have also fixed the L10n with help from you, thank you. I have disabled the sign in dialog until it gets cleaned up and ESN support is integrated. |
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| namespace vm { using namespace ps3; } | |||
|
|
|||
| std::map<s32, std::pair<s32, s32>> converters; | |||
|
|
|||
There was a problem hiding this comment.
It's not only wrong because you forgot to remove it, it's bad idea to define variables in headers this way.
Also fixed newlines, CellSailEvent, fixed CellMusic changes, fixed console_write, fixed L10n changes and removed the login dialog for now, until a more proper implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly ported safe stuff over from #1205. Other stuff that was in that one, I'll probably further cleanup (cellGcm and RSX) and then will include as a part of another PR in the future.