New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logs: Output multiple log-messages at a time (optimization) #12255
Conversation
In order to have any meaning, you should provide several benchmarks with random data. (I can't find my own anymore) |
Well, I've configured the game Brink to use SPU Trace log level and Trace on GUI frame (extreme and rapid log spam), disabled video output, and waited for its access violation to occur with it being put to fatal so it freezes the emulation. PR: 22.2147969 seconds. |
thanks. what about stack mode etc. ? |
Stack mode now literally reduces all GUI log text update calls for a repeated message to one instead of for each repetition as master so it's obvious it's faster. |
I'd like to see the numbers anyway |
GUI log panel has been notorious for hurting performance in many games, although disabling it by default is quite undesirable.
Attempt to improve its performance instead.
Processing time in Brink until access violation with SPU log level set to trace:
Master: 62.6159297 seconds.
PR: 22.2147969 seconds.